debug: allow a single debug extension to provide multiple configs #100794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a debug extension provided multiple dynamic configurations, we would just use the first debugger -- whatever that was. This change now shows all configurations for which dynamic configs are registered. I also adjusted the picker to automatically select the first item if there's only a single configuration provided. This works well for the debug terminal, but also means that the user doesn't see the name of the selected item, which might not be desirable. Open to pushback. Together these finish the request for a separate top-level contribution for the terminal in #98054 Finally, with that adjustment I made a tweak so that the picker shows up in a `busy` state while extensions are activating. Previously you would select a dynamic configuration title and could have a few seconds of delay before the picker came up, which is probably not desirable.
connor4312
added
the
debug
isidorn
requested changes
Jun 23, 2020
src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
Outdated
Show resolved
Hide resolved
isidorn
reviewed
Jun 23, 2020
|
@connor4312 thanks a lot for this PR. Good work overall! I like the optimisation to not bother the user if there is only one Configuration! As for PRs in general, I am a big fan and keep em coming. Also feel free to split PRs in multiple if they tackle seperate things since that makes it easier for me to review and merge. |
|
Looks great. Merging in. 🍻 ☀️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a debug extension provided multiple dynamic
configurations, we would just use the first debugger -- whatever that
was. This change now shows all configurations for which dynamic configs
are registered.
I also adjusted the picker to automatically select the first item if
there's only a single configuration provided. This works well for the
debug terminal, but also means that the user doesn't see the name of
the selected item, which might not be desirable. Open to pushback.
Together these finish the request for a separate top-level contribution
for the terminal in #98054
Finally, with that adjustment I made a tweak so that the picker shows
up in a
busystate while extensions are activating. Previously youwould select a dynamic configuration title and could have a few seconds
of delay before the picker came up, which is probably not desirable.