Closing inactive editors will still update breadcrumb

[jrieken]

Testing #98019

• see attached GIF
• open and pin an editor, make sure it has breadcrumbs
• press cmd+w
• editor stays but breadcrumbs flash

[bpasero]

@jrieken hm, Cmd+W at least should always close an editor, even if pinned. Did you assign anything special to Cmd+W?

[jrieken]

Yeah, looks like I have "close all editors in group"

[bpasero]

@jrieken that would explain it, and is covered by #99037

I can look why the breadcrumb flickers, that seems wrong to me.

[bpasero]

It looks like we would update breadcrumbs even if no editors are closing, I fixed that with 64955f1

Looking at

vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts

Line 430 in 64955f1

this.updateBreadcrumbsControl();

we still might have cases where we call updateBreadcrumbsControl even if the editors that close are not the active one. Leaving that up to you to clean up, e.g. maybe this should only call when the active editor is part of the ones to close.

[jrieken]

I would need to know if the active tab was closed or not but it seems that this.group.activeEditor is already set to the new, active editor when reaching this code:

vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts

Line 385 in e6470a9

closeEditor(editor: IEditorInput): void {

@bpasero Am I missing something or this this too far down the line?

[jrieken]

nvm - looks like openEditor is called always before close (when closing a single tab) and then breadcrumbs are already updated. Only when closing all tab special breadcrumb updating is needed...

[bpasero]

@jrieken closeEditors may also be called without the active one being included, e.g. "Close Others". How about this code:

closeEditors(editors: IEditorInput[]): void {
	this.handleClosedEditors();

	if (this.group.activeEditor && editors.indexOf(this.group.activeEditor) !== -1) {
		this.updateBreadcrumbsControl();
	}
}

To make sure breadcrumbs update when the list of closed editors includes the active one. I can see that reduces flicker when running "Close Others".

[jrieken]

For closeEditor I see the same. Once the call reached me, the active editor is already updated and hence never in the list closed editors. Meaning, I'd never update the breadcrumbs here... Tho, it might be enough to only update the breadcrumbs when no more editor is around (which means hide breadcrumbs)