Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune presentation of input/output in the debug console #87599

Closed
isidorn opened this issue Dec 23, 2019 · 6 comments
Closed

Tune presentation of input/output in the debug console #87599

isidorn opened this issue Dec 23, 2019 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 23, 2019

Follow up work from last milestone to make the input / output more distinguishable.

@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Dec 23, 2019
@isidorn isidorn added this to the January 2020 milestone Dec 23, 2019
@isidorn isidorn self-assigned this Dec 23, 2019
isidorn added a commit that referenced this issue Jan 21, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jan 21, 2020

I have improved the alignment so it now looks like this.
As @joaomoreno points out the issue is that we use the same icon as for the tree expando which can resonate badly with the user.
We should use a different icon. However if I use a arrow right / left codicon I personally do not like the effect since due to an illusion they do not look centereted

Thus I think we should introduce a new icon. Something that looks like a chevron but is a bit different. So some stylised version of > <
@misolori is it possible to design something like this?

Screenshot 2020-01-21 at 15 11 00

Screenshot 2020-01-21 at 15 25 37

@joaomoreno
Copy link
Member

joaomoreno commented Jan 21, 2020

I remember discussing this back in December. Alternatives discussed were:

  • Only use an icon for input
  • Only use an icon for output
  • Separate input/output pairs with a horizontal separator

Let's explore those as well.

@isidorn
Copy link
Contributor Author

isidorn commented Jan 21, 2020

Good ideas.
Horizontal separator: the repl no longer would look like an editor and I personally dislike this.

Only use an icon for input:

Screenshot 2020-01-21 at 15 36 44

Only use an icon for output:

Screenshot 2020-01-21 at 15 37 40

I personally like how it looks when we only use an icon for input.
I would push this to insiders to get feedback.
Let me know what you think! And thanks a lot

@joaomoreno
Copy link
Member

joaomoreno commented Jan 21, 2020

Horizontal separator: the repl no longer would look like an editor and I personally dislike this.

But the repl isn't an editor. The Chrome dev tools repl uses horizontal separators.

@isidorn
Copy link
Contributor Author

isidorn commented Jan 21, 2020

Yeah, I am aware of both those things. IMHO it just feels like too much for me with all the horisontal lines. Chrome uses nice transparent color for lines and I could be convinced to also try that, but I would first like to try the one arrow approach.

Our users are always swtiching between the editor and repl, while the chrome does not have a regular editor. Since VSCode is an editor, and our users mostly look at the editor imho it makes sense to make the repl resemble the editor as much as it can.

@joaomoreno
Copy link
Member

Since VSCode is an editor, and our users mostly look at the editor imho it makes sense to make the repl resemble the editor as much as it can.

It's especially because our users constantly switch between both that it is important to differentiate between them such that they don't get annoyed when they try to edit the repl or run commands in the editor.

But, you're right, let's roll with the current approach since it already addresses some pain points. 👍

@isidorn isidorn added the verification-needed Verification of issue is requested label Jan 22, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jan 28, 2020
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Jan 31, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @isidorn @connor4312 and others