Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path is hidden in call stack selected frame #85626

Closed
roblourens opened this issue Nov 26, 2019 · 3 comments
Closed

Path is hidden in call stack selected frame #85626

roblourens opened this issue Nov 26, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

image

@isidorn isidorn added this to the November 2019 milestone Nov 27, 2019
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 27, 2019
@isidorn
Copy link
Contributor

isidorn commented Nov 27, 2019

This is how all inline actions are behaving in all our views.
On hover the action is shown and on focus.
Another reason for doing this is accessibility, such that the users can tab to the action. The path is still read out to screen readers due to the aria label.

I understand that this might be an issue, since we are auto focusing stack frames when a break point is hit, so users will not see the path.

We can say that call stack behaves special and only shows the inline action on hover. And the restart frame is accessibile via context menu.

Let me know what you think
also fyi @weinand

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 27, 2019
@roblourens
Copy link
Member Author

Which other views do this? Search has inline actions that show on hover, but it still shows the file path on the right side.

We can say that call stack behaves special and only shows the inline action on hover.

I like that.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Nov 28, 2019
@isidorn
Copy link
Contributor

isidorn commented Nov 28, 2019

Call Stack does this for threads and sessions.
Git does this.

However let's go with your suggestion, since frames get auto focused, this might be strange. Adding bug label so we get this verified

sandy081 pushed a commit that referenced this issue Nov 28, 2019
@alexr00 alexr00 added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants