Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] Use textDocument.rangeFormatting.dynamicRegistration instead of workspace.symbol.dynamicRegistration? #81592

Closed
iquiw opened this issue Sep 29, 2019 · 4 comments
Closed

[json] Use textDocument.rangeFormatting.dynamicRegistration instead of workspace.symbol.dynamicRegistration? #81592

iquiw opened this issue Sep 29, 2019 · 4 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Milestone
September 2019

Comments

@iquiw
Copy link

iquiw commented Sep 29, 2019

VSCode JSON Language Server README says format option is only applicable if the client supports dynamicRegistration for rangeFormatting, while the code uses workspace.symbol.dynamicRegistration.

Should it use textDocument.rangeFormatting.dynamicRegistration?

HTML also does the same.
@aeschli aeschli added this to the September 2019 milestone Sep 30, 2019
@aeschli aeschli added json JSON support issues bug Issue identified by VS Code Team member as probable bug labels Sep 30, 2019
@aeschli
Copy link
Contributor

aeschli commented Sep 30, 2019

Good catch! Thanks!

aeschli added a commit that referenced this issue Sep 30, 2019
@aeschli
[json] Use textDocument.rangeFormatting.dynamicRegistration instead o…
3259fbf 
…f workspace.symbol.dynamicRegistration? #81592
@iquiw
Copy link
Author

iquiw commented Sep 30, 2019

workspace.rangeFormatting.dynamicRegistration => textDocument.rangeFormatting.dynamicRegistration ?

@aeschli
Copy link
Contributor

aeschli commented Sep 30, 2019

Yes, my bad, thanks!

aeschli added a commit that referenced this issue Sep 30, 2019
@aeschli
#81592 again
78a6b2d
@aeschli aeschli closed this as completed Sep 30, 2019
@iquiw
Copy link
Author

iquiw commented Sep 30, 2019

Thank you!!

@iquiw iquiw mentioned this issue Oct 1, 2019
Merged
@mjbvz mjbvz added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

No branches or pull requests
3 participants
@iquiw @aeschli @mjbvz