-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote terminals don't resolve variables when restored on startup #81231
Comments
Nice find, looks like we're trying to resolve variables before the service that does it is able to do so. |
@Tyriar I would like to take this. Could you please guide me? |
@lifez this one will need you to do a bit of debugging/investigation here: vscode/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts Lines 193 to 204 in 06f94fb
I think that if statement is not entered on launch because |
@Tyriar Thank you!! I would like to take this one |
@Tyriar I cannot start the code. Could you please help me please?
|
@lifez that means the node modules are using a different version of Electron that what's running, we recently changed the version fo Electron from 6->4->6. You should
|
I cannot make this work. I think it because Catalina nodejs/node-gyp#1927 So that I won't work on this issue. |
I cannot reproduce it on Windows 10. Maybe this thread should be closed, if the issue has already been fixed. |
I am also getting similar error
|
@JoyceBabu try recompiling as in #81231 (comment), we change the Electron version sometimes which means all native node modules will stop working until you do that. |
Minor correction: ”not only on launch" – remove the “not”. The issue I saw was only a problem when the Terminal was opening on Launch. But once Code and completed launching, I was able to successfully open a terminal with the setting.
I haven’t tried this recently, since I changed my setting to work-around this issue. If you are unable to repro, I can try again with the latest build.
From: Daniel Davis <[email protected]>
Sent: Tuesday, June 16, 2020 4:19 PM
To: microsoft/vscode <[email protected]>
Cc: Andy Jacobs <[email protected]>; Author <[email protected]>
Subject: Re: [microsoft/vscode] Terminal window doesn't open at startup (#81231)
@Tyriar <https://github.com/Tyriar> I wouldn't mind taking a shot at this, but just want to confirm that I've understood the bug properly. If I set my Terminal -> Integrated Cwd setting to ${workspaceFolder}, my terminal never loads and always throws an error, not only on launch, but it sounds like the issue being reported is exclusive to launch/startup. Let me know if I'm misunderstanding.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#81231 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYOGSWTFHYEAYVLFPZ6KE3RW7HTJANCNFSM4IYXM37A> . <https://github.com/notifications/beacon/ABYOGSQDZYXLJDPWGLYPOSDRW7HTJA5CNFSM4IYXM37KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEZY4J6A.gif>
|
@andyj513 I suspect this is still happening. |
Issue Type: Bug
I changed my Terminal->Integrated: Cwd setting to "$(workspaceFolder)". Now, when Code starts up, the Terminal does not open, and I get a notification: "The terminal shell CWD "/home/gpudb/gpudb-dev-7.0/gpudb-core/gaiadb-cluster/${workspaceFolder}" does not exist". This happens every time I launch Code.
However, once Code has loaded, I can then do Ctrl-` to open a Terminal window, and it works as expected (also every time). Note that this is doing Remote development (so the Terminal is opening a session on my remote machine).
I suspect the issue is that Code is trying to start the Terminal before $workspaceFolder is set, but it is set later, when I manually open the Terminal. It is a fairly easy work-around, but am reporting it in case this is not the expected behavior.
VS Code version: Code 1.38.1 (b37e54c, 2019-09-11T13:35:15.005Z)
OS version: Windows_NT x64 10.0.18362
Remote OS version: Linux x64 4.15.0-62-generic
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Extensions (20)
The text was updated successfully, but these errors were encountered: