Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcast service debt #70831

Closed
jrieken opened this issue Mar 20, 2019 · 5 comments
Closed

Fix broadcast service debt #70831

jrieken opened this issue Mar 20, 2019 · 5 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Mar 20, 2019

While working on #70319 I have moved the IBroadcastService-service definition to common. However, there is only an implementation for electron-node (not electron-node-less).

Looking at the service and it's usages it seems like a kitchen-sink service that should be avoidedby using "topic"-services, like a service that manages debug output or one that's about windows and themes.

@weinand weinand added the debt Code quality issues label Mar 20, 2019
@isidorn
Copy link
Contributor

isidorn commented Mar 20, 2019

I am fine with dismantling it into smaller services and introducing one only for the debug use case

fyi @bpasero

@bpasero
Copy link
Member

bpasero commented Mar 20, 2019

Yeah a good idea 👍

@weinand
Copy link
Contributor

weinand commented Mar 20, 2019

I've created #70835 for the debug case.

@bpasero bpasero self-assigned this Mar 20, 2019
@bpasero bpasero added this to the March 2019 milestone Mar 20, 2019
@bpasero bpasero removed their assignment Mar 25, 2019
@bpasero bpasero modified the milestones: March 2019, April 2019 Mar 25, 2019
@bpasero
Copy link
Member

bpasero commented Mar 25, 2019

Leaving vscode:changeColorTheme (from parts splash) for @aeschli

@isidorn
Copy link
Contributor

isidorn commented Apr 3, 2019

I have moved the debug stuff as covered by this item #70835
@aeschli if you like my changes from there I can do the same for your vscode:changeColorTheme and we fully get rid of the broadcastService.

@aeschli aeschli modified the milestones: April 2019, May 2019 May 6, 2019
aeschli added a commit that referenced this issue May 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

5 participants