-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broadcast service debt #70831
Comments
I am fine with dismantling it into smaller services and introducing one only for the debug use case fyi @bpasero |
Yeah a good idea 👍 |
I've created #70835 for the debug case. |
Leaving |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
While working on #70319 I have moved the
IBroadcastService
-service definition to common. However, there is only an implementation for electron-node (not electron-node-less).Looking at the service and it's usages it seems like a kitchen-sink service that should be avoidedby using "topic"-services, like a service that manages debug output or one that's about windows and themes.
The text was updated successfully, but these errors were encountered: