Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid "import 'vscode'" outside extension host #70807

Closed
bpasero opened this issue Mar 20, 2019 · 3 comments
Closed

Avoid "import 'vscode'" outside extension host #70807

bpasero opened this issue Mar 20, 2019 · 3 comments
Assignees
@roblourens
Labels
debt Code quality issues
Milestone
April 2019

Comments

@bpasero
Copy link
Member

bpasero commented Mar 20, 2019

Looks like webview and search are offenders:

image

//cc @jrieken
@bpasero bpasero added the debt Code quality issues label Mar 20, 2019
@jrieken
Copy link
Member

jrieken commented Mar 20, 2019 •
edited
Loading

related to #70319 - I have already extracted/duplicated interfaces into exthost.protocol.ts

@roblourens
Copy link
Member

All of this is in the extension host for types only. If we duplicate the vscode.d.ts types somewhere else, what guarantees that they will match vscode.d.ts?

mjbvz added a commit that referenced this issue Mar 21, 2019
@mjbvz
Don't import 'vscode' in webview code
376fca8 
#70807
@mjbvz mjbvz removed their assignment Mar 21, 2019
@jrieken
Copy link
Member

jrieken commented Mar 21, 2019

If we duplicate the vscode.d.ts types somewhere else, what guarantees that they will match vscode.d.ts?

The compiler will guarantee that. Everything is linked together in extHost.api.impl.ts

@roblourens roblourens added this to the April 2019 milestone Mar 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues
Projects
None yet
Milestone
April 2019
Development

No branches or pull requests
4 participants
@roblourens @bpasero @jrieken @mjbvz