Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal line to problem hover #69360

Closed
weinand opened this issue Feb 25, 2019 · 5 comments
Closed

Add horizontal line to problem hover #69360

weinand opened this issue Feb 25, 2019 · 5 comments
Assignees
Labels
editor-hover Editor mouse hover ux User experience issues
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 25, 2019

testing #69204:

I suggest to separate the hover's status bar with the Peek Problem and Quick Fixes actions from the "contents area" by another horizontal line:

2019-02-25_12-47-25

@sandy081 sandy081 added ux User experience issues editor-hover Editor mouse hover labels Feb 25, 2019
@sandy081 sandy081 added this to the February 2019 milestone Feb 25, 2019
@weinand
Copy link
Contributor Author

weinand commented Feb 25, 2019

And please consider to use a smaller font for the hovwer's status bar (or better: the same size as the main status bar).

@sandy081
Copy link
Member

@weinand This is how it looks if we use same style as status bar

image

Does not it look odd with the rest of the hover?

sandy081 added a commit that referenced this issue Feb 25, 2019
@sandy081
Copy link
Member

I think it looks good after adding a default status bar background

image

sandy081 added a commit that referenced this issue Feb 25, 2019
@bpasero
Copy link
Member

bpasero commented Feb 25, 2019

@sandy081 I like it a lot. should "Quick Fix" appear first though?

@sandy081
Copy link
Member

Done

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-hover Editor mouse hover ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants