Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Cannot focus out of the integrated terminal #6731

Closed
alexdima opened this issue May 24, 2016 · 1 comment
Closed

Accessibility: Cannot focus out of the integrated terminal #6731

alexdima opened this issue May 24, 2016 · 1 comment
Assignees
@Tyriar
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
July 2016

Comments

@alexdima
Copy link
Member

Testing #6654

  • click into the integrated terminal
  • try to Tab out, does not work
  • in other places (editor) we use ctrl+m as a toggle between the widget trapping focus or not
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels May 24, 2016
@Tyriar Tyriar added this to the July 2016 milestone Jul 5, 2016
@Tyriar Tyriar mentioned this issue Jul 5, 2016
Closed
@Tyriar Tyriar added the terminal Integrated terminal issues label Jul 5, 2016
@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2016

Need xtermjs/xterm.js#118 to be pushed for this.

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 16, 2016
Tyriar added a commit that referenced this issue Jul 22, 2016
@Tyriar
Uplevel xterm.js
e9f712e 
Adds custom keydown handler for #6731
Tyriar added a commit that referenced this issue Jul 22, 2016
@Tyriar
Allow focus to escape the integrated terminal
2e3acff 
When ctrl+m is pressed (only use default keybinding for now), tab will not be
passed to the pty and instead will propogate up and shift focus.

Part of #6731
@Tyriar Tyriar closed this as completed in 2cc6141 Jul 22, 2016
This was referenced Jul 25, 2016
Closed
Closed
@isidorn isidorn added the verified Verification succeeded label Jul 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
July 2016
Development

No branches or pull requests
3 participants
@isidorn @Tyriar @alexdima