Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URI#with #6678

Closed
jrieken opened this issue May 23, 2016 · 1 comment
Closed

Add URI#with #6678

jrieken opened this issue May 23, 2016 · 1 comment
Assignees
@jrieken
Labels
api feature-request Request for new features or functionality
Milestone
June 2016

Comments

@jrieken
Copy link
Member

jrieken commented May 23, 2016

Similar to how we can check Ranges and Postions for equality we should be able to check URIs for equality. It would serve as a short hand for the popular uri.toString() === anotherUri.toString() which you find often. Question is if some path normalisation should be applied on top?
@jrieken jrieken self-assigned this May 23, 2016
@jrieken jrieken added api feature-request Request for new features or functionality labels May 23, 2016
@jrieken jrieken changed the title Add URI#isEqual Add URI#isEqual/withXZY May 25, 2016
@jrieken
Copy link
Member Author

jrieken commented May 25, 2016

and also the with methods we have on the underlying type such that uri can be modified nicely. This might prevent some issues when path/uri-math happens

@jrieken jrieken mentioned this issue May 25, 2016
Closed
jrieken added a commit that referenced this issue May 30, 2016
@jrieken
debt - refactor URI.withXYZ methods, #6678
91f26f8
jrieken added a commit that referenced this issue Jun 3, 2016
@jrieken
expose Uri#with to allow deriving a new Uri from an existing, #6678
2071e2f
jrieken added a commit that referenced this issue Jun 3, 2016
@jrieken
align with-signatures, add change-object overload to Range#with, #6678
4f33eea
jrieken added a commit that referenced this issue Jun 3, 2016
@jrieken
change object style for Position#with and Position#translate, #6678
63e98eb
@jrieken jrieken closed this as completed Jun 3, 2016
@jrieken jrieken added this to the June 2016 milestone Jun 3, 2016
@jrieken jrieken changed the title Add URI#isEqual/withXZY Add URI#with Jun 27, 2016
@jrieken jrieken mentioned this issue Jun 27, 2016
Closed
1 task
@egamma egamma mentioned this issue Jun 28, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api feature-request Request for new features or functionality
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
1 participant
@jrieken