Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "command" input variable type #64362

Closed
weinand opened this issue Dec 4, 2018 · 1 comment
Closed

support "command" input variable type #64362

weinand opened this issue Dec 4, 2018 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan

Comments

@weinand
Copy link
Contributor

weinand commented Dec 4, 2018

Input variables have introduced an excellent way to parameterize and configure builtin interactive variables. But they lack support for contributing new variables.

But there is an easy way to combine the new input variables with the existing command based variables: a new input variable type "command" makes it possible to turn any command based variable into an input variable.

Example:

	"inputs":[
		{
			"label": "processPicker",
			"description": "Select process to attach to",
			"type": "command",
			"command": "extension.processes.pickProcess",
                         "args": {
			    "processTypes": [ "node", "iojs", "electron" ]
                         }
		}
	],

/cc @alexr00

@weinand weinand added the feature-request Request for new features or functionality label Dec 4, 2018
@weinand weinand assigned weinand and alexr00 and unassigned alexr00 Dec 4, 2018
@weinand weinand added this to the December 2018 milestone Dec 6, 2018
@weinand weinand changed the title support "command" input varibale type support "command" input variable type Dec 6, 2018
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 23, 2018
@weinand
Copy link
Contributor Author

weinand commented Dec 23, 2018

  • a user input of type command is now supported (and there are tests for it).
  • variables are now prompted for in a single pass: as a result input and command variables are now evaluated in the order they appear in the task or launch config.
  • cancelling a prompt aborts the task or launch config.
  • validation of an input structure only occurs for the needed ones; so errors in other inputs are not flagged and don't confuse the user.
  • intellisense now uses the "enumDescriptions" schema feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants