Allow completion details to be selected

[octref]

Issue Type: Feature Request

Currently when clicking or dragging on the completion details, it'll go away, making it impossible to select text inside it.

VS Code version: Code - Insiders 1.26.0-insider (4fa62b2, 2018-08-03T12:25:19.888Z)
OS version: Darwin x64 17.7.0

[ramya-rao-a]

The parameter hint widget allows for text to be selected, we should be able to do the same with the details part of the suggest widget.
PRs are welcome.

Edit Its the hover widget that allows for text to be selected, not parameter hint

[ozyx]

I'll give this one a go.

[luiszun]

I cannot select the contents of the parameter hint widget either, although it does not disappear on click like the details of the suggest widget.
I double checked I'm looking at the right widget by breaking on show()
in \src\vs\editor\contrib\parameterHints\parameterHintsWidget.ts

[ozyx]

I also noticed this while investigating. Can confirm that the parameter hint widget text is not selectable. Right now I have a commit which is making the suggest completion details selectable. Just working on tidying it up as currently selecting the text causes keyboard shortcuts to no longer function (arrow keys for selecting a suggestion, esc key for exiting the popup). I'm probably just missing something somewhere.

[ramya-rao-a]

@luiszun @ozyx Below shows selection and copy possible in the parameter hint widget

[luiszun]

@ramya-rao-a It seems like that the widget you're showing there is the hover widget.
That one shows on src\vs\editor\contrib\hover\hoverWidgets.ts at showAt()

The one referred in the issue happens on suggestWidgets.ts, and the parameter hint on parameterHintsWidget.ts
Am I terribly lost?

I apologize for the text-only description, I need to find how to make those nifty gifs :)

edit: Added the nifty gif :)

[ramya-rao-a]

@luiszun You are right. My mistake. Yes, I was referring to the hover widget. I have updated my comment above.

[luiszun]

Good to know! I was worried that I was just adding confusion to this issue :)

[wistcc]

Actually, I wasn't able to mimic the hover widget behavior but here is another way to fix it.