Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling window.foo = 5 does not do make the variable global in Webview script #48715

Closed
octref opened this issue Apr 25, 2018 · 3 comments
Closed
Assignees
Labels
verification-needed Verification of issue is requested verified Verification succeeded webview Webview issues
Milestone

Comments

@octref
Copy link
Contributor

octref commented Apr 25, 2018

#48453

When I try to assign a global variable, such as doing window.foo = 5 in the Webview script, it is not available in the console of Webview developer tools.

OK, actually found I can access it in here:

image

I think this should go together with point 5 in #48705. Being able to interact with their script can help people with development/debugging a lot.

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2018

Good suggestion, I'll add a note on this. We cannot change the inspector behavior as far as I know

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 26, 2018
@mjbvz mjbvz added this to the April 2018 milestone Apr 26, 2018
@mjbvz mjbvz added the webview Webview issues label Apr 26, 2018
mjbvz added a commit to microsoft/vscode-docs that referenced this issue Apr 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2018

For verification, make sure the docs section on this makes sense and that you can follow the instructions to see state set in a webview

@mjbvz mjbvz closed this as completed Apr 26, 2018
@sbatten
Copy link
Member

sbatten commented Apr 26, 2018

Fixed a quick typo in the section but makes sense

@sbatten sbatten added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verification-needed Verification of issue is requested verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants