Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are createWebviewPanel options mandatory param when it can be {} #48594

Closed
Tyriar opened this issue Apr 24, 2018 · 2 comments
Closed

Why are createWebviewPanel options mandatory param when it can be {} #48594

Tyriar opened this issue Apr 24, 2018 · 2 comments
Assignees
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2018

#48453

We should be able to safely make this an optional param?

@mjbvz mjbvz added this to the April 2018 milestone Apr 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 27, 2018

Couldn't come up with a compelling API reason why it should be optional (or why it shouldn't be), so let's just keep it as is

@mjbvz mjbvz closed this as completed Apr 27, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Apr 27, 2018
@Tyriar Tyriar reopened this Apr 27, 2018
@mjbvz mjbvz removed the *as-designed Described behavior is as designed label Apr 27, 2018
mjbvz added a commit that referenced this issue Apr 27, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 27, 2018
@mjbvz mjbvz closed this as completed in 2161513 Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 11, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants