We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#48453
We should be able to safely make this an optional param?
The text was updated successfully, but these errors were encountered:
Couldn't come up with a compelling API reason why it should be optional (or why it shouldn't be), so let's just keep it as is
Sorry, something went wrong.
Because it seems like it would be more consistent making it optional than not:
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L1118
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L1131
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L4511
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L4520
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L4657
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L4669
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L5481
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L5492
There are places where options are mandatory when all the properties are optional like this:
https://github.com/Microsoft/vscode/blob/ee36a84ff1abb0b8bc7509f651b0d97a734cd14c/src/vs/vscode.d.ts#L5500
But it doesn't make much sense to use {} here.
{}
Make webview options optional
d801331
Fixes #48594
2161513
mjbvz
No branches or pull requests
#48453
We should be able to safely make this an optional param?
The text was updated successfully, but these errors were encountered: