-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track user focus across editor and integrated terminal #47615
Comments
(Experimental duplicate detection) |
@IlyaBiryukov why do you need to know what's focused? |
@Tyriar one of features of our extension is following user through the IDE. We already can do this for editor, but not other windows. |
@IlyaBiryukov what does this mean exactly? What happens as a result of the user clicking in the terminal panel or the explorer? |
@Tyriar If this "follow" mode is turned on, and the user clicks on a (shared) terminal, we want other users to get the corresponding shared terminal focused. Clicking on the explorer (the folder view) won't make the following users to activate their explorers though. We're interested in following the user to places where others can contribute or see what the user is changing. |
We have kind of decided against this, esp when it comes to webview or tree views which are entirely private to extensions. Also there are UI pieces, like the release notes editor, which take focus but for which we don't have plans to expose in the API. |
Ok, how about just the active terminal window? |
@Tyriar Is something like |
@jrieken yes we could add this if you think it's a good idea given all the other panels. |
@Tyriar when do you think you can do this? |
@IlyaBiryukov you also need a |
Yep |
I'll include this with the big PR for #46192 |
Issue Type: Feature Request
Right now only active text editor can be tracked with
window.activeTextEditor
. Though users can focus other UI elements, like integrated terminals, there is no way to tell when user switches focus from the text editor to the integrated terminal, or from one terminal to another.Because of that user tracking in our extension cannot tell when user has changed focus to an integrated terminal, or switched active terminals.
We'll need something like
window.activeTextEditor
, but more generic, e.g.activeWindow: TextEditor | Terminal | .... | undefined
The text was updated successfully, but these errors were encountered: