Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + . (auto import in typescript) no longer works #47002

Closed
ayyash opened this issue Mar 30, 2018 · 5 comments
Closed

Ctrl + . (auto import in typescript) no longer works #47002

ayyash opened this issue Mar 30, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues
Milestone

Comments

@ayyash
Copy link

ayyash commented Mar 30, 2018

Issue Type: Bug

Ctrl + . shortcut to add missing imports in typescript no longer works

VS Code version: Code - Insiders 1.22.0-insider (6c22e21, 2018-03-30T05:16:39.261Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6650U CPU @ 2.20GHz (4 x 2208)
Memory (System) 15.93GB (8.98GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions (19)
Extension Author (truncated) Version
scss-scan aar 0.1.67
htmltagwrap bra 0.0.7
npm-intellisense chr 1.3.0
vscode-stylesheet-formatter dba 0.2.0
githistory don 0.4.0
tslint eg2 1.0.28
vscode-npm-script eg2 0.3.3
auto-rename-tag for 0.0.15
vscode-npm-dependency how 1.2.0
Angular2 joh 2.15.0
code-beautifier mic 2.0.3
vscode-less mrm 0.6.3
vscode-scss mrm 0.6.2
mssql ms- 1.3.0
azure-account ms- 0.3.3
csharp ms- 1.14.0
sass-indented rob 1.4.8
bootstrap4-vscode the 4.1.1
vscode-todo-highlight way 0.5.12
@vscodebot vscodebot bot added the insiders label Mar 30, 2018
@ayyash ayyash changed the title Ctrl + . no longer works Ctrl + . (auto import in typescript) no longer works Mar 30, 2018
@roblourens
Copy link
Member

Please include some more details about your project

@ayyash
Copy link
Author

ayyash commented Apr 1, 2018

Angular typescript code, what other details do you need?
preferences set: "typescript.autoImportSuggestions.enabled": true
using tslint that comes by default in angular template, using "typescript": "2.6.2"
It was working fine until the last update, it only imports while typing the class name now, but if I ignore, then try to ctrl+. to import, nothing happens.

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 2, 2018

@jrieken I believe this was broken by df7ee60. I'll check-in a fix and take it into 1.22. Please quickly review my fix to make sure it makes sense for the original issue that df7ee60 targeted

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Apr 2, 2018
@mjbvz mjbvz added this to the March 2018 milestone Apr 2, 2018
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues labels Apr 2, 2018
@mjbvz mjbvz closed this as completed in 0dd7c79 Apr 2, 2018
mjbvz added a commit that referenced this issue Apr 2, 2018
Fixes #47002

Use the correct grouping for the not null assertion
@mduu
Copy link

mduu commented Apr 23, 2018

Still having this issue in v1.22.2.

@mingzepeng
Copy link

Still having this issue in v1.22.2. windows 10
while I'm using jsx, auto imports could not works well
let foo = <TypeInfoSelect />
ctrl+. on TypeInfoSelect , auto imports could not work

@vscodebot vscodebot bot locked and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

5 participants