Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug console should inherit editor settings #45156

Closed
keithbentrup opened this issue Mar 6, 2018 · 24 comments
Closed

debug console should inherit editor settings #45156

keithbentrup opened this issue Mar 6, 2018 · 24 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@keithbentrup
Copy link

  • VSCode Version: 1.20.1
  • OS Version: OSX 10.11.6

Steps to Reproduce:

  1. I enabled the user setting {"editor.acceptSuggestionOnEnter": "off"}
  2. In a debugging session, the console still interprets "enter" as a suggestion completion.

This is not intuitive and forces the user to adapt to different ways of typing in the debug console vs. the editor.

Does this issue occur when all extensions are disabled?: Yes/No
Yes

@isidorn
Copy link
Contributor

isidorn commented Mar 7, 2018

Debug Console input does inherit editor settings, except these ones
And among them is the acceptSuggestionOnEnter. It uses a custom acceptSuggestionOnEnter behavior.

@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 7, 2018
@isidorn isidorn added this to the Backlog milestone Mar 7, 2018
@isidorn isidorn removed their assignment Mar 7, 2018
@weinand weinand added the *out-of-scope Posted issue is not in scope of VS Code label Sep 17, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 17, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@isidorn
Copy link
Contributor

isidorn commented May 11, 2020

Since we got multiple requests for this reopening for now and assinging to backlog

@isidorn isidorn reopened this May 11, 2020
@isidorn isidorn self-assigned this May 11, 2020
@isidorn isidorn removed the *out-of-scope Posted issue is not in scope of VS Code label May 11, 2020
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Nov 2, 2020
@AnthonyWeston
Copy link

This issue is a daily struggle. I don't see much discussion around the value of this fix, so is there any specific reasoning behind the decision to tag this out-of-scope?

Debug Console input does inherit editor settings, except these ones
And among them is the acceptSuggestionOnEnter. It uses a custom acceptSuggestionOnEnter behavior.

Is this configurable? If it is, I can't find a setting for it. If this issue won't be fixed, would it be an option to make it configurable?

@pdimh
Copy link

pdimh commented Nov 9, 2020

is there a way to disable suggestion for debug console? i mean, if this wont be fixed, it should be nice to disable suggestion

@isidorn
Copy link
Contributor

isidorn commented Nov 10, 2020

Not at the moment. There is only the option to disable the suggestions from history via
"debug.console.historySuggestions": false

@Mark-Sims
Copy link

Disabling history suggestions (via @isidorn's comment) doesn't completely solve the issue. There are still intellisense suggestions that appear, and are subsequently accepted with the Enter key.

For example, if I initiate a Python debugging session, and type import re (attempting to import Python's RegEx module) intellisense suggests RecursionError and if I hit Enter, that suggestion is accepted, and import RecursionError is executed.

This is with the following setting: "editor.acceptSuggestionOnEnter": "off" (As the OP described.)

@christian-nils
Copy link

I agree, it does not make much sense that the behaviour from the normal code and from the debug console are different. Please consider fixing this issue.

@vike2000
Copy link

isidorn commented on 7 Mar 2018

Debug Console input does inherit editor settings, except these ones
And among them is the acceptSuggestionOnEnter. It uses a custom acceptSuggestionOnEnter behavior.

In the regular editor (1) I get the expected behavior that I connect with the following of settings.json, but in the debug console (2) I guess they behave more like default "languageDefined"/"always" or just forced all true.

	"editor.autoClosingBrackets": "never",
	"editor.autoClosingQuotes": "never",
	"editor.autoSurround": "never",
	"editor.matchBrackets": "never",

I do not see any of them in the quoted link to repl.ts getReplInputOptions(). Any tips on what to do?

+1 AnthonyWeston on 9 Nov 2020 hoping this could be made configurable.


  1. extension bmewburn.vscode-intelephense-client language contribution to php
  2. extension felixfbecker.php-debug debug contribution

@Mark-Sims
Copy link

Any chance this can be reconsidered? Even if it isn't the highest priority at the moment, I don't feel that it should be Closed.

@edwardreed81
Copy link

I agree - I routinely execute the wrong snippet multiple times in a row on the debug console. It is extremely frustrating.

@isidorn
Copy link
Contributor

isidorn commented Feb 11, 2021

Let's reopen this. Though not plans to tackle it in the near future. Thanks

@isidorn isidorn reopened this Feb 11, 2021
@isidorn isidorn removed the *out-of-scope Posted issue is not in scope of VS Code label Feb 11, 2021
@stevage
Copy link

stevage commented Feb 18, 2021

This issue (specifically #97439) is incredibly infuriating. Especially when you have a variable in scope that you want to view the value of, yet the debugger auto-completes on "enter" and gives you something completely different.

vscode-autocomplete

@sayginburak
Copy link

This is frustrating and unbelievable that it still hasn't been fixed!

@muhamuhamuha
Copy link

Very frustrating it hasn't been fixed yet!

@Jargonautika
Copy link

Please please please fix this problem. It is ridiculous.

@vderm
Copy link

vderm commented Apr 6, 2021

Zzz...

@pgs31
Copy link

pgs31 commented Apr 29, 2021

I would really appreciate a fix for this, it's super annoying! Thanks guys..

@Rob-DL
Copy link

Rob-DL commented May 4, 2021

This is a very very annoying issue.
Example with the python debug console>:

> x = [1 ,2 ,3, 4] <Enter>
> x = [1, 2, 3]  <Enter>  <-- Gets autocompleted to x = [1, 2, 3, 4]]

Problem, my valid code is now converted into invalid code and I get an error. Even if the code were valid I still don't get the result I want.

Expected behavior: Don't autocomplete on enter in a REPL environment by default.

@matoles
Copy link

matoles commented May 10, 2021

I too would very much like this fixed

@onurtore
Copy link

Bruh, really... Do I have to learn electron and fix it by myself... Trust me, it's not gonna be nice.

@PhilippHils
Copy link

This issue is the only downside of using VSCode for me - apart from that it integrates great in my python workflow.

@isidorn
Copy link
Contributor

isidorn commented Aug 17, 2021

This is fixed now via #128768 and #108439

Closing as duplicate as we do not want to allow debug console to inherit arbitrary editor settings

@isidorn isidorn closed this as completed Aug 17, 2021
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests