Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Console: Accept Suggestions on Enter not working #128768

Closed
chopin2256 opened this issue Jul 15, 2021 · 10 comments
Closed

Debug Console: Accept Suggestions on Enter not working #128768

chopin2256 opened this issue Jul 15, 2021 · 10 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@chopin2256
Copy link

Issue Type: Bug

  1. Go to Debug Console
  2. Type in any object with expected attributes
  3. As attributes are displayed in intellisense, press enter
  4. The command executes instead of autocomplete
  5. Tab will autocomplete, enter will not.

VS Code version: Code 1.58.1 (2aeda6b, 2021-07-13T06:58:28.115Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

@dmiller-aon
Copy link

Per the release notes this was apparently done on purpose, as people would type what they wanted and hit return, only to have their input unexpectly replaced by the top-level suggestion. I was happy enough to hit the escape key to dismiss the Intellisense box when no correction was desired. The enter key still works to accept the suggestion in the main editing panel, so it is kind of awkward that it doesn't work in the Debug console. It would be nice to be able to control this behavior with a preference - I'm not sure I want to switch to using the Tab key everywhere. I certainly won't use different keystrokes in different panels!

@chopin2256
Copy link
Author

chopin2256 commented Jul 15, 2021

Oh I see. I feel the same way, why switch from Enter to Tab if you are used to "Enter". As you suggest, maybe the team can make this an option then:

  • Enter autocompletes for editor (yes / no) - which they have already
  • Enter autocompletes for Debug Console (yes / no).

Simple! I'm going to leave this open, maybe it will get picked up!

@weinand weinand assigned isidorn and unassigned weinand Jul 16, 2021
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 16, 2021
@bededict-cumberbach
Copy link

Maybe similar to the editor option "editor.acceptSuggestionOnEnter": "on", create a new option "debug.console.acceptSuggestionOnEnter": "on" ?

Hope this will be added soon.

@ewerybody
Copy link

Hello! Yeah, I was just baffled by what happens to me! I never complete stuff with Tab
Why would the behaviour be different from the editor!?
I'd rather have things NOT executed on Enter anyway and have it Ctrl+Enter instead.

However: Just bending Enter to always execute feels really bad! There should be some room to customize things and at least optionally enable the old behaviour? I mean I also found myself having stupid suggestions put into the Debug Console via Enter but it was never a problem.

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2021

Thanks for your feedback.
More details here on the motivation behind this change #108439 (comment)

I am open for adding an option in the future, but for now I prefer to keep this open to gather more feedback.

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 26, 2021
@isidorn isidorn added this to the Backlog milestone Jul 26, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 4, 2021

@weinand also feels like a setting should be added. So let's assign this to August so we introduce a setting.
As @bededict-cumberbach suggested let's use the "debug.console.acceptSuggestionOnEnter": "on" | "off". With "off" being the default

@isidorn isidorn modified the milestones: Backlog, August 2021 Aug 4, 2021
@isidorn isidorn added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Aug 4, 2021
@isidorn isidorn closed this as completed in 39127ad Aug 4, 2021
@isidorn isidorn added verification-needed Verification of issue is requested and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 4, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 4, 2021

To verify:

Set "debug.console.acceptSuggestionOnEnter": "on", type something in the debug console, have some suggestions, press enter and make sure the suggestion is accepted and not evaluated.

Set "debug.console.acceptSuggestionOnEnter": "off", type something in the debug console, have some suggestions, press enter and make sure the current input is evaluated and the suggestion is ignored.

@ewerybody
Copy link

Nice! Maybe when this is back we can try to find solutions to mitigate the initial issue lead to this change. 🤔
Like said: I also had the problem with adding suggestions when I wanted only what I just typed ... But that can also happen in the text editor! So what makes it worse in the debug console??!

@eliyahu2
Copy link

That would be great to have an option to autocomplete on "Enter" ... Thanks!

@alexr00 alexr00 added the verified Verification succeeded label Aug 24, 2021
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Aug 27, 2021
@ewerybody
Copy link

Thanks again for the option! I feel super relieved now that I don't have to stress myself to remember pressing Tab pcheeew 😅

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants