-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process explorer as a separate renderer window #41045
Comments
@RMacfarlane @kieferrm @egamma fyi I did some initial prep work (https://github.com/Microsoft/vscode/tree/ben/taskmanager) to open a window from the main process that shows a tree with process info. I still need to polish it a little bit so that it works in a full build (currently it only works when running out of sources). I think in its current state the missing work is to polish the way how processes and their CPU/memory usage are displayed but otherwise it is already functional: I am happy to hand this over or to code review the changes to how the information is displayed. I think we also have to decide if we want to show more information in the tree than just the cpu/memory (e.g. a way to open logs for a specific process? a way to connect a debugger?). |
I suggest to use the code from https://github.com/weinand/vscode-processes:
|
@weinand why are we not using this approach also for the command line? seems a bit weird to have 2 implementations in our code base for this only on Windows. |
The (Windows-) code in VS Code is too slow for using it in a polling loop. |
I pushed changes so that the window also opens properly from a built version of VS Code. |
The PowerShell script is not slow in general. It samples the CPU for ~5 seconds to get a more realistic picture when we capture the CPU load since Windows doesn't store any historical data. @weinand the wmic command btw does the same with the only difference of one sampling for 1 second once which is the default for the underlying OS call. If I run the command in the command prompt it takes ~2 seconds to return. In general I think spawning a process every 1 - 2 seconds might not be nice when it comes to battery live. We should rather have a process we spawn once that puts itself to sleep and send the information back over a pipe or stdio. |
This results in a long pause when running |
I can add a message explaining that this takes some time. I can reduce the sample duration as well, however this might give a incorrect picture. Since we want to use this to track down problems I would not opt to lower this too much. |
It now shows
|
Move the vscode-process extension inside of VSCode. Like the process reporter, launch it as a separate window.
The text was updated successfully, but these errors were encountered: