Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal does not support dim/faint style #36238

Closed
Tyriar opened this issue Oct 13, 2017 · 3 comments
Closed

Terminal does not support dim/faint style #36238

Tyriar opened this issue Oct 13, 2017 · 3 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
October 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2017 •
edited
Loading 

echo -e 'normal \x1b[2mfaint \x1b[0m'

screen shot 2017-10-13 at 9 25 35 am

Upstream PR: xtermjs/xterm.js#1043
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Oct 13, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Oct 13, 2017
@Tyriar Tyriar added this to the October 2017 milestone Oct 13, 2017
@Tyriar Tyriar closed this as completed in fa5556c Oct 13, 2017
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@Tyriar @sandy081
Add support for dim text in the terminal
e61a655 
Fixes #36238
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Oct 30, 2017
@mjbvz mjbvz added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Oct 31, 2017
@monk-time
Copy link

This doesn't seem to work on Win7x64 with a freshly unzipped VSCode Insiders 1.19.0 (and also in Release 1.18) and Git for Windows 2.15.0 (and also with 2.14.2):

clipboard02

I don't think it's a Windows/GfW issue, because Git Bash by itself can display faint text:

2017-11-09_15-47-06

Should I open a new issue?

@Tyriar
Copy link
Member Author

Tyriar commented Nov 9, 2017

@monk-time if it doesn't work in Windows this is because we emulate xterm via winpty which has limited capabilities. I don't think it's worth creating an issue for this.

@monk-time
Copy link

@Tyriar Oh, I see. I was confused by [the changelog] that implied that this is fixed on all platforms.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@Tyriar @monk-time @mjbvz