Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should have a workspace folder picker API in the Extension host #32936

Closed
dbaeumer opened this issue Aug 22, 2017 · 5 comments · Fixed by #34648
Closed

We should have a workspace folder picker API in the Extension host #32936

dbaeumer opened this issue Aug 22, 2017 · 5 comments · Fixed by #34648
Assignees
@bpasero
Labels
api feature-request Request for new features or functionality on-testplan workbench-multiroot Multi-root (multiple folders) issues
Milestone
September 2017

Comments

@dbaeumer
Copy link
Member

Extensions now need to scope certain actions (like settings changes) to a workspace folder. In a multi workspace folder setup the need to ask the user which folder to use. To make such a picker the same for all extensions we should offer API for this.
@vscodebot vscodebot bot added the api label Aug 22, 2017
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Aug 22, 2017
@bpasero bpasero added this to the On Deck milestone Aug 22, 2017
@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Aug 22, 2017
@bpasero
Copy link
Member

bpasero commented Aug 22, 2017

/cc @sandy081 @jrieken

@sandy081
Copy link
Member

How different is this that an extension show a quick pick with workspace folders and asking to pick?

@dbaeumer
Copy link
Member Author

To always make it look the same and use the name as the label and the directory as the description.

1 similar comment
@dbaeumer
Copy link
Member Author

To always make it look the same and use the name as the label and the directory as the description.

@cipheroth
Copy link

Don't do this

@bpasero bpasero modified the milestones: On Deck, Backlog Sep 1, 2017
@bpasero bpasero modified the milestones: September 2017, Backlog Sep 11, 2017
@kieferrm kieferrm mentioned this issue Sep 11, 2017
Closed
48 tasks
This was referenced Sep 15, 2017
Closed
Closed
bpasero added a commit that referenced this issue Sep 19, 2017
@bpasero
Workspace folder picker command (for #32936)
7039249
@bpasero bpasero mentioned this issue Sep 19, 2017
Merged
bpasero added a commit that referenced this issue Sep 20, 2017
@bpasero
Workspace folder picker command (for #32936) (#34648)
492ae2a 
* Workspace folder picker command (for #32936)

* fix test

* make this proper API
@bpasero bpasero mentioned this issue Sep 21, 2017
Closed
2 tasks
@deysaikat95 deysaikat95 mentioned this issue Sep 25, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
api feature-request Request for new features or functionality on-testplan workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
September 2017
4 participants
@bpasero @dbaeumer @cipheroth @sandy081