Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown mode cannot open links that contains some codes by percent-encoding. #32026

Closed
kou1okada opened this issue Aug 4, 2017 · 4 comments
Closed
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach uri

Comments

@kou1okada
Copy link

I wrote some links to web page and clicked it.
But all links, that were containing code of 0x80-0xff by percent-encoding, could not open browser.

For example:

* Following links can open browser:
  * [@](https://www.google.co.jp/search?q=%62%69%67)
  * [@](https://www.google.co.jp/search?q=%00) (only Linux)
  * [@](https://www.google.co.jp/search?q=%01)
  * ...
  * [@](https://www.google.co.jp/search?q=%7f)
* Following links cannot open browser:
  * [@](https://www.google.co.jp/search?q=%91%E5)
  * [@](https://www.google.co.jp/search?q=%00) (only Windows)
  * [@](https://www.google.co.jp/search?q=%80)
  * ...
  * [@](https://www.google.co.jp/search?q=%ff)

Every links show balloon tips of "Ctrl + click to follow link".
And the preview mode of markdown shows same behavior.

My environment is below:

  • Windows
    • Windows 7 Ultimate 64bit Japanese
    • vscode 1.14.2
    • Firefox 54.0.1 64bit
  • Linux
    • Ubuntu 14.04.5 LTS 64bit
    • vscode 1.14.2
    • Firefox 54.0 64bit

Good regard.

@vscodebot vscodebot bot added the search Search widget and operation issues label Aug 4, 2017
@roblourens roblourens assigned rebornix and unassigned roblourens Aug 4, 2017
@roblourens roblourens removed the search Search widget and operation issues label Aug 4, 2017
@roblourens roblourens assigned mjbvz and unassigned rebornix Aug 4, 2017
@roblourens roblourens added the markdown Markdown support issues label Aug 4, 2017
@mjbvz mjbvz assigned jrieken and mjbvz and unassigned mjbvz Aug 4, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 4, 2017

@jrieken The root cause is that Uri.parse('https://www.google.co.jp/search?q=%91%E5') throws an error when we call decodeUriComponent('q=%91%E5')

Problem is also related to #31805

@jrieken
Copy link
Member

jrieken commented Aug 14, 2017

Interesting...

@jrieken jrieken added under-discussion Issue is under discussion for relevance, priority, approach uri and removed markdown Markdown support issues labels Nov 13, 2017
@jrieken jrieken added the *out-of-scope Posted issue is not in scope of VS Code label Sep 11, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 11, 2018

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 11, 2018
@kou1okada
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach uri
Projects
None yet
Development

No branches or pull requests

5 participants