Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet increment/decrement by 0.1 Error #31281

Closed
sou-lab opened this issue Jul 23, 2017 · 9 comments
Closed

Emmet increment/decrement by 0.1 Error #31281

sou-lab opened this issue Jul 23, 2017 · 9 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
July 2017

Comments

@sou-lab
Copy link

sou-lab commented Jul 23, 2017

  • VSCode Version: 1.14.2
  • OS Version: MacOS 10.12.6

Steps to Reproduce:

  1. Emmet Increment/Decrement by 0.1

decrementnumberbyonetenth

Reproduces without extensions: No
@vscodebot vscodebot bot added the emmet Emmet related issues label Jul 23, 2017
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 23, 2017 •
edited
Loading

Nice catch @sou-lab !

Thanks for logging the issue. Fixed with 9b6cc9f

The fix will be out in Monday's Insiders

Looks like you have set emmet.useNewEmmet to true
Please do try out rest of the emmet commands and file issues if you find any

I intend to set emmet.useNewEmmet to true by default in the next update (1.15)

@ramya-rao-a ramya-rao-a added this to the July 2017 milestone Jul 23, 2017
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jul 23, 2017
@sou-lab
Copy link
Author

sou-lab commented Jul 24, 2017

Thank you for support😃
I try Insiders on Monday.

@jens1o
Copy link
Contributor

jens1o commented Jul 28, 2017

Err. This issue is not fixed when using hex-color codes(I'm hunting for edge cases 👅).
Having this:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Document</title>
    <style>
        body {
            background-attachment: fixed;

            color: #231230;
        }
    </style>
</head>
<body>
    
</body>
</html>

Select the code:
image

Decrement it by 0.1:

image
Not bad, isn't it?

@ramya-rao-a
Copy link
Contributor

@jens1o Am confused... what is not fixed?

@jens1o
Copy link
Contributor

jens1o commented Jul 29, 2017 •
edited
Loading

Hex-Colors can't be decremented by 0.1 nor incremented at all(with < 1), because Hex Colors only can be three or six digits number prepended by a #. So it's not possible to decrement them by this step, so I would expect an error message.

Personally, I would like that the steps will be converted to hex number and then let the math happen. At the moment, emmet does not care about different number systems.

ramya-rao-a added a commit that referenced this issue Jul 31, 2017
@ramya-rao-a
Emmet: Show error when failed to eval math expression Fixes #31281
da83dff
@ramya-rao-a
Copy link
Contributor

Updated to show error message if unable to evaluate given expression

@jens1o
Copy link
Contributor

jens1o commented Jul 31, 2017

Err, that's not fixing this problem? You can still increment hex color codes, can't you?

@ramya-rao-a
Copy link
Contributor

So it's not possible to decrement them by this step, so I would expect an error message.

I was addressing the error message part of your comment

We can use #31681 which you logged to track the hex color code issue

@jens1o
Copy link
Contributor

jens1o commented Jul 31, 2017

Okay.

@mjbvz mjbvz added the verified Verification succeeded label Aug 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
4 participants
@sou-lab @jens1o @mjbvz @ramya-rao-a