Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the compare action label easier to understand when file names are identical #30515

Closed
Dominik-K opened this issue Jul 12, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@Dominik-K
Copy link

If I've selected a file a.yaml for comparison in multi-root folder rootA and use the context-menu on another file b.yaml in root folder rootB, then showing "Compare with rootA/a.yaml", i.e. adding the root path rootA, instead of just a.yaml would be helpful.

cc #28344

@bpasero
Copy link
Member

bpasero commented Jul 12, 2017

@Dominik-K well we actually never show any parent in that menu simply because we do not have much space. I think your suggestion applies already for single folder case too where you might want to know which file to compare to.

@bpasero bpasero added file-explorer Explorer widget issues feature-request Request for new features or functionality labels Jul 12, 2017
@bpasero bpasero removed their assignment Jul 12, 2017
@Dominik-K
Copy link
Author

@bpasero Oh, you're right. I didn't noticed this before as inside one project == folder, the filenames are mostly unique. But with the new, useful multi-root folders, it offers the opportunity to easily compare files with the same name, e.g. Kubernetes configurations, across different projects.

@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Jul 12, 2017
@bpasero bpasero changed the title Display multi-root path in "Compare with" menu entry Make the compare action label easier to understand when file names are identical Aug 17, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 17, 2017
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues labels Aug 17, 2017
@bpasero
Copy link
Member

bpasero commented Aug 17, 2017

Pushed changes for 2 things:

  1. always show both file names in the compare action label

image

  1. show enough context in case the filenames are identical (using the same algorithm we have when having the same file name opened multiple times

image

@bpasero bpasero closed this as completed Aug 17, 2017
bpasero added a commit that referenced this issue Aug 17, 2017
@bpasero bpasero self-assigned this Aug 29, 2017
@jrieken jrieken added the verified Verification succeeded label Aug 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants