Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: persist TypeScript version choice to workspace settings #30069

Closed
OliverJAsh opened this issue Jul 3, 2017 · 2 comments
Closed
Labels
*as-designed Described behavior is as designed typescript Typescript support issues

Comments

@OliverJAsh
Copy link
Contributor

When selecting a version of TypeScript through the "Select TypeScript Version" command, it would be good if this was persisted to the workspace settings.

I understand this is persisted to local storage, but that will not survive the boundaries of machines, nor a project rename.

@vscodebot vscodebot bot added the typescript Typescript support issues label Jul 3, 2017
@OliverJAsh OliverJAsh changed the title Persist TypeScript version choice to workspace settings Suggestion: persist TypeScript version choice to workspace settings Jul 3, 2017
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Jul 3, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 3, 2017

We support setting typescript.tsdk in the workspace settings but for security reasons we always require that users opt into using the workspace version of typescript. That's where local storage comes into play.

It's an configuration extra step, but we do need do it this way to ensure that opening workspaces from unknown sources is a safe operation. Closing as by design. Please let me know if you have any questions about the current design or thoughts on a better opt in style flow for selecting the typescript version.

@mjbvz mjbvz closed this as completed Jul 3, 2017
@OliverJAsh
Copy link
Contributor Author

OliverJAsh commented Jul 3, 2017 via email

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

2 participants