Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Open Changes button not displayed as disabled for files without any changes #26425

Closed
cateyes99 opened this issue May 11, 2017 · 8 comments · Fixed by #137297
Closed

The Open Changes button not displayed as disabled for files without any changes #26425

cateyes99 opened this issue May 11, 2017 · 8 comments · Fixed by #137297
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone

Comments

@cateyes99
Copy link

VSCode Version: 1.12.1
OS Version: OS X EI Capitan 10.11.3

Steps to Reproduce:

  1. Open some project from GitHub.
  2. Open a file A.cs which has no fresh changes at all.
  3. Stay on the editor of A.cs, and notice the button of Open Changes on the top right corner above the editor doesn't display as disbled! Clicking it has no effect of course, but it should display as disable in this case just like what in the old versions.
@joaomoreno
Copy link
Member

Can't fix without #21131, closing for now.

@cateyes99
Copy link
Author

since it connot be fixed without #21131, should this be kept open and linked to #21131 then?

@joaomoreno
Copy link
Member

Sure.

@joaomoreno joaomoreno reopened this May 12, 2017
@joaomoreno joaomoreno added this to the Backlog milestone May 12, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels May 12, 2017
@joaomoreno
Copy link
Member

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.

Thanks for your understanding. Happy coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
@sana-ajani
Copy link
Contributor

Hoping to re-open this because I got this as a feedback item from a few CS educators. They notice their students clicking it accidentally and being confused when there is no apparent action.

@sana-ajani sana-ajani reopened this Jun 29, 2021
@joaomoreno joaomoreno assigned eamodio and unassigned joaomoreno Jun 29, 2021
@lramos15 lramos15 self-assigned this Jul 12, 2021
@lramos15 lramos15 modified the milestones: Backlog, July 2021 Jul 12, 2021
@alexr00 alexr00 added the verified Verification succeeded label Jul 29, 2021
@bpasero
Copy link
Member

bpasero commented Aug 3, 2021

I think this has regressed, I now miss this button when a file is staged.

@lramos15
Copy link
Member

lramos15 commented Aug 3, 2021

Fixed regression with 3232379

@lszomoru
Copy link
Member

lszomoru commented Nov 5, 2021

There is another regression (#131739), so I will be reverting this fix for this, and will refactor it.

@lszomoru lszomoru reopened this Nov 5, 2021
@lszomoru lszomoru assigned lszomoru and unassigned eamodio and lramos15 Nov 5, 2021
@lszomoru lszomoru removed verified Verification succeeded insiders-released Patch has been released in VS Code Insiders labels Nov 5, 2021
@lszomoru lszomoru modified the milestones: July 2021, November 2021 Nov 5, 2021
@alexr00 alexr00 added the verified Verification succeeded label Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants