"Git: Open changes" action and button gone missing :(

[CComparon]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.59.1
• OS Version: Win10 21H1 19043.1165

Steps to Reproduce:

1. On a git-managed repo, open a file that has local changes (compared to local HEAD)
2. Used to have the "Git: Open changes" action available and the corresponding button below, but that's no longer the case.
   
3. Only alternative is to go manually through the Source Control panel, locate the file of interest, and do "Open Changes" on it.

I remember seeing an issue mentioning that regression a month or two ago, it got fixed, but somehow didn't make its way into the 1.59.1 release.

Thanks,
Cyril

[CComparon]

Installed 1.60.0 and still no way to Open Changes on the current file 😫

[jacktkk]

I met the same problem, could anyone help?

[eamodio]

/gifPlease

I can't reproduce this -- can you reproduce with 1.61 (insiders)?

If so, can you attach a gif please?

[CComparon]

Here is a screencast showing my installed extensions and the issue itself.
It's taken with vscode 1.60.1. The insider build suffers from the same problem.
It seems it's happening in WSL2 only as I don't have the issue with native windows, MacOS or native Ubuntu.
@jacktkk are you running vscode on Windows with WSL backend?

OpenChangesActionIsGone.mp4

[zero41120]

VSCode with WSL doesn't show the open changes button.
In most cases, I assume using the "open changes with previous revision" achieve the same as the missing open working tree button.

[CComparon]

VSCode with WSL doesn't show the open changes button.

This had always been working perfectly until ~2 month ago.

"open changes with previous revision" achieve the same as the missing open working tree button.

Unfortunately it shows a diff with different left/right references than what "Open changes" does, which doesn't allow to stage/unstage changes.
"open changes with previous revision" opens a tab named "${filename} (${git_hash})" whereas Open changes "${filename} (Working Tree)"

Again, the situation is:

• the "git: Open changes" button is gone
• the "git: Open changes" action is gone
• I can trigger this action by clicking directly on a file in the Source Control panel
  

[KyleRAnderson]

I am observing the same behaviour on two Windows devices running VSCode 1.60.2. For me however, the button doesn't show up in any scenario; not when running with a WSL remote, not when using remote-containers, and not with no remotes either.

System information:

VS Code version: Code 1.60.2 (7f6ab54, 2021-09-22T12:00:31.514Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No
Fetching remote diagnostics for 'Dev Container: C++' failed: Canceled
Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.88GB (2.30GB free)
Process Argv	--crash-reporter-id f1b78eeb-acbd-4eea-9d09-3b3a3b816af2
Screen Reader	no
VM	25%

Fetching remote diagnostics for 'Dev Container: C++' failed: Canceled

Item	Value
Remote	Dev Container: C++
OS	Linux x64 5.10.16.3-microsoft-standard-WSL2
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2111)
Memory (System)	4.82GB (0.68GB free)
VM	0%

Item	Value
Remote	Dev Container: C++
OS	Linux x64 5.10.16.3-microsoft-standard-WSL2
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2111)
Memory (System)	4.82GB (0.68GB free)
VM	0%

Item	Value
Remote	Dev Container: C++
OS	Linux x64 5.10.16.3-microsoft-standard-WSL2
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2111)
Memory (System)	4.82GB (0.68GB free)
VM	0%

Extensions (16)

Extension	Author (truncated)	Version
Bookmarks	ale	13.2.1
prettier-vscode	esb	9.0.0
python	ms-	2021.9.1246542782
vscode-pylance	ms-	2021.9.4
jupyter-keymap	ms-	1.0.0
remote-containers	ms-	0.194.3
remote-ssh	ms-	0.65.8
remote-ssh-edit	ms-	0.65.8
remote-wsl	ms-	0.58.2
vscode-remote-extensionpack	ms-	0.21.0
slim	sia	0.1.2
vscode-ruby	win	0.28.0
Bookmarks	ale	13.2.1
gitlens	eam	11.6.0
todo-tree	Gru	0.0.214
cpptools	ms-	1.6.0

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30364498
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30371810
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30364666
pythonvspyt187:30373474
pydsgsc2:30361791
vsqsis300:30374797
vsaa593:30376534

[CComparon]

Issue is still present after yesterday's version update

Version: 1.61.0
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:13:09.652Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

[CComparon]

I'm surprised there are so few vscode/WSL users that the incidence is not higher.
Now been months without being able to easily stage changes and it seems I'm not the only one here :/
Any idea how I may help narrow down the root cause?

[CComparon]

Just upgraded to 1.61.2 and issue is still present.

System information:

Item	Value
CPUs	AMD Ryzen 7 PRO 4750U with Radeon Graphics (16 x 1697)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	29.73GB (6.91GB free)
Process Argv	--crash-reporter-id 938c2017-f9b4-49cf-9cb3-9c6797fbfdbe
Screen Reader	no
VM	31%

Extensions (27)

Extension	Author (truncated)	Version
vscode-styled-jsx	bla	2.0.0
sqitch-plan	joe	0.0.1
remote-containers	ms-	0.202.5
remote-ssh	ms-	0.65.8
remote-ssh-edit	ms-	0.65.8
remote-wsl	ms-	0.58.2
vscode-remote-extensionpack	ms-	0.21.0
vscode-openapi	42C	4.6.4
vscode-tailwindcss	bra	0.7.1
npm-intellisense	chr	1.4.0
path-intellisense	chr	2.4.0
vscode-eslint	dba	2.2.2
gitlens	eam	11.6.1
EditorConfig	Edi	0.16.4
prettier-vscode	esb	9.0.0
vscode-pull-request-github	Git	0.31.1
openapi-lint	mer	1.2.0
git-graph	mhu	1.30.0
vscode-docker	ms-	1.17.0
color-highlight	nau	2.5.0
vscode-versionlens	pfl	1.0.9
vscode-yaml	red	1.0.0
node-pack	Swe	0.1.16
vscode-open-in-github	sys	1.15.0
vscodeintellicode	Vis	1.2.14
docker	vsc	1.0.0
yaml	vsc	1.0.0

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30384386
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwt:30382697
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30364666
pythonvspyt187:30373474
vsqsis400:30386382
vsaa593cf:30376535
vssld246:30386377

[lszomoru]

@CComparon, sorry about that. I have tracked this regression down to the fix for #26425. For the time being, I have reverted that fix (4297ff8) until I refactor it to avoid such a regression. The fix will be released in Insiders next week, and in Stable next month.

[CComparon]

@lszomoru Thanks a ton!
I was even able to hot apply the patch myself and the "open change" action is back!!
Still not clear to me why it works but glad it does