Add pattern matching to when clause, when contributing menus

[fbricon]

• VSCode Version: 1.12.0
• OS Version: MacOS Sierra 10.12.4

In vscode-java, we'd like to be able to provide context menus for all gradle files. The current when clause is limited to language types ("when": "resourceLangId == groovy") or a single file name ("when": "resourceFilename == 'build.gradle'").

It would be helpful if there was support for glob pattern matching, as @jrieken mentioned in #3192 (comment)

[gawicks]

Hi, Any update on this?

[jrieken]

@chrisdias I will push an additional change that expands this to support normal regular expressions instead of just glob-patterns. We figured that's more powerful and closer to ST

[eamodio]

Will this be usable in matching any when clause value? Can you give an example?

[jrieken]

You write key =~ pattern, so resourceFilename =~ /.*Docker\d{2,3}.*$/ will execute this /.*Docker\d{2,3}.*$/.test(context.getValue('resourceName')). A sample from my dummy extensions (matches filenames ending in z)

"explorer/context": [
{
	"command": "extension.sayHello",
	"when": "resourceFilename =~ /z$/"
}]

[eamodio]

This is AWESOME! Should reduce the number of duplicate menu items I need to define

[jrieken]

Slight update on this: The value must be enclosed in slashes, so someName =~ /regexp/. I have updated above sample

[weinand]

@jrieken FYI:
I tried to apply this feature to the "loaded script view" by following the entry in the release notes:

But without much success.

After looking into the test item and the corresponding feature item, I noticed that the latest syntax uses regular regexp syntax.

I've taken the liberty to change the release notes to this:

I did not attempt to clarify why /docker/ actually matches "Docker files".

[webdeb]

Hmm, I am writing a simple copyName extension, and would like to copy any resourceName.

It works without any when clause, but the menu item also shows up, when r-clicking inside the empty space. I would like to prevent it.

Is there something like this "when": isResource ?

[webdeb]

Ok I found resourceIsFile. And its actually what I was looking for. But I did not found it in the docs, but code base.