Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension recommendations for Vue.js #24538

Closed
chrmarti opened this issue Apr 11, 2017 · 6 comments
Closed

Add extension recommendations for Vue.js #24538

chrmarti opened this issue Apr 11, 2017 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Collaborator

Test tour #23385

@mjbvz mjbvz self-assigned this Apr 11, 2017
@mjbvz mjbvz added the feature-request Request for new features or functionality label Apr 20, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 10, 2017

Updated for stable and insiders

@mjbvz mjbvz closed this as completed May 10, 2017
@mjbvz mjbvz added this to the May 2017 milestone May 10, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label May 26, 2017
@roblourens
Copy link
Member

roblourens commented May 31, 2017

It says "The 'Vue' extension is recommended ..." should be 'vetur'? That's the only vue extension that actually shows up in the recommended list.

@roblourens roblourens reopened this May 31, 2017
@mjbvz mjbvz closed this as completed May 31, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 31, 2017

Agree, other recommended extensions use generic names (c++, powershell, ...) but in this case we want the specific extension name

Should be fixed in distro

@roblourens
Copy link
Member

roblourens commented May 31, 2017

Well those are the actual names for those extensions :)

@chrmarti
Copy link
Collaborator Author

@mjbvz Maybe update the main repo's package.json to point to the new commit in vscode-distro, so that doesn't fall through the cracks?

mjbvz added a commit that referenced this issue Jun 1, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 1, 2017

Thanks @chrmarti. Done with f8c01e9

@bpasero bpasero added the verified Verification succeeded label Jun 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants