Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing References code lens #24209

Closed
egamma opened this issue Apr 7, 2017 · 3 comments · Fixed by #24469
Closed

Confusing References code lens #24209

egamma opened this issue Apr 7, 2017 · 3 comments · Fixed by #24469
Assignees
@mjbvz
Labels
javascript JavaScript support issues typescript Typescript support issues ux User experience issues
Milestone
April 2017

Comments

@egamma
Copy link
Member

egamma commented Apr 7, 2017

Testing in this setup #23895

Get this Code lense with '0 References' in src\app\app.component.ts
image

Clicking the references link just shows an empty peek, it is not clear what is being search for.
image
@egamma egamma added the typescript Typescript support issues label Apr 7, 2017
@egamma
Copy link
Member Author

egamma commented Apr 7, 2017

Now I understand what is going on:
image

The reference in the template isn't found by the Angular Language Service extension.

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 7, 2017

@egamma Do you suggest we don't show the peek view from zero references code lens? Or should the no results peek view have more info on what would normally be displayed?

@egamma
Copy link
Member Author

egamma commented Apr 10, 2017

@mjbvz since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.

@mjbvz mjbvz mentioned this issue Apr 10, 2017
Merged
@mjbvz mjbvz added the javascript JavaScript support issues label Apr 10, 2017
@mjbvz mjbvz added this to the April 2017 milestone Apr 10, 2017
@mjbvz mjbvz added the ux User experience issues label Apr 10, 2017
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 12, 2017
@mjbvz
Allow Code Lenses to Provide only a Title
a0cb432 
Fixes microsoft#24209

**Bug**
Currently, for the js/ts references code lens, even if there are zero references you can click on the lens. This display an empty peek view

**Fix**
Allow code lenses to only register a title for the lens with no actual backing command
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
javascript JavaScript support issues typescript Typescript support issues ux User experience issues
Projects
None yet
Milestone
April 2017
Development

Successfully merging a pull request may close this issue.

Allow Code Lenses to only Provide a Title and no Backing Command mjbvz/vscode
2 participants
@egamma @mjbvz