Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating an un-activated extension, I get "Restart Extensions" #213837

Open
TylerLeonhardt opened this issue May 29, 2024 · 3 comments · Fixed by #214007
Open

After updating an un-activated extension, I get "Restart Extensions" #213837

TylerLeonhardt opened this issue May 29, 2024 · 3 comments · Fixed by #214007
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality
Milestone

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented May 29, 2024

Steps to Reproduce:

  1. Follow the steps here: Extension updating issue #210837 (comment)
  2. See the "Restart Extensions":
image
@TylerLeonhardt TylerLeonhardt changed the title After updating an un-activated extension, I get After updating an un-activated extension, I get "Restart Extensions" May 29, 2024
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels May 30, 2024
@sandy081 sandy081 added this to the June 2024 milestone May 30, 2024
sandy081 added a commit that referenced this issue May 31, 2024
sandy081 added a commit that referenced this issue May 31, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 31, 2024
@sandy081 sandy081 added the author-verification-requested Issues potentially verifiable by issue author label Jun 24, 2024
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@TylerLeonhardt, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 524d1ec of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jun 26, 2024
@TylerLeonhardt
Copy link
Member Author

I still see this issue:

Image

Steps are even simpler I feel:

  • Create a profile A
  • Install the latest pre-release of redhat.java
  • gear icon -> "install another version" -> pick one
  • 🐛 see Restart Extensions but the extension isn't activated yet so I don't see why that button is shown

@TylerLeonhardt TylerLeonhardt added the verification-found Issue verification failed label Jun 26, 2024
@sandy081 sandy081 modified the milestones: June 2024, July 2024 Jun 27, 2024
@sandy081 sandy081 modified the milestones: July 2024, August 2024 Jul 25, 2024
@sandy081 sandy081 removed verification-found Issue verification failed author-verification-requested Issues potentially verifiable by issue author labels Jul 25, 2024
@sandy081
Copy link
Member

This scenario is not supported from the beginning. An update always required restarting extensions. See this comment

// This extension is already known (most likely at a different version)
// so it cannot be added again unless it is removed first

This is a valid request to support this feature.

@sandy081 sandy081 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jul 29, 2024
@sandy081 sandy081 modified the milestones: August 2024, Backlog Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants