Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline doesn't always clear the old value #211178

Closed
amunger opened this issue Apr 23, 2024 · 4 comments · Fixed by #211205
Closed

Outline doesn't always clear the old value #211178

amunger opened this issue Apr 23, 2024 · 4 comments · Fixed by #211205
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-toc-outline verified Verification succeeded
Milestone
April 2024

Comments

@amunger
Copy link
Contributor

amunger commented Apr 23, 2024

Testing #210961

image

This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro
@amunger
Copy link
Contributor Author

amunger commented Apr 23, 2024 •
edited
Loading

  1. open a notebook with several markdown headers in insiders
  2. open the same notebook in stable and add a header
    🐛 outline in insiders is not updated (stable does update when doing this in reverse)
  3. remove a different markdown header in insiders
    🐛 screencheese

@amunger amunger assigned amunger and unassigned Yoyokrazy Apr 23, 2024
@amunger
Copy link
Contributor Author

amunger commented Apr 23, 2024

Recording 2024-04-23 at 15 16 44

nb2.ipynb.txt

@DonJayamanne
Copy link
Contributor

Thanks I can replicate this issue.

@DonJayamanne DonJayamanne assigned DonJayamanne and unassigned amunger Apr 23, 2024
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug notebook-toc-outline labels Apr 23, 2024
@DonJayamanne DonJayamanne mentioned this issue Apr 24, 2024
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Apr 24, 2024
@vscodenpa vscodenpa added this to the April 2024 milestone Apr 24, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 25, 2024
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Apr 25, 2024
@rzhao271
Copy link
Contributor

Giving the issue back to Aaron to verify. My Python install's a bit broken.

@connor4312 connor4312 added the verified Verification succeeded label Apr 25, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-toc-outline verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

Handle model changes when updating nb outline microsoft/vscode
6 participants
@DonJayamanne @amunger @connor4312 @rzhao271 @Yoyokrazy @vscodenpa