Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Editing large notebooks with the Notebook outline view visible #210961

Closed
3 of 5 tasks
DonJayamanne opened this issue Apr 22, 2024 · 4 comments
Closed
3 of 5 tasks

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Apr 22, 2024

Refs: #209787

Complexity: 2

Create Issue


Pre-requisites

  1. Install latest pre-release version of Jupyter extension
  2. Create a notebook with at least 200 code cells & 200 markdown cells (the more cells you have the better)
    • Code cells could contain could be print("Hello World")
    • Markdown cells needs to be more complex such as
    # Header 1
    ## Header 2
    ### Header 3
    • Tip: Best to have them alternating.
    • You can create one code cell and one markdown cell, then copy them and paste them a few times.
    • Then copy all cells and copy & paste them
  3. Ensure notebook outline is visible
  4. Enable the setting Notebook: Show Code Cells Symbols
  5. Enable Notebook: Sticky Scroll

Test Steps

  1. Open the notebook
  2. Start editing the notebook
  3. Verify you can edit the code cells and markdown cells and there is no lag in editing text (previously this would be slow)
  4. Verify the outline gets updated as and when you update the markdown & or code cells.
@isidorn
Copy link
Contributor

isidorn commented Apr 23, 2024

@DonJayamanne can you please provide a good notebook file to test this?
I can not manually copy / paste a 100 times these cells, since Copy Cell Down does not support multi-cell select. Or if it does, do let me know how to trigger.

Thank you 🙏

@jrieken
Copy link
Member

jrieken commented Apr 23, 2024

@isidorn I can copy-paste multiple cells. Also, at the end of the day these are just JSON files that you can edit

@jrieken jrieken removed their assignment Apr 23, 2024
@isidorn
Copy link
Contributor

isidorn commented Apr 23, 2024

Good point. I forgot it has a nice JSON representation. I was able to create the cells. Thanks for the tip.

@amunger
Copy link
Contributor

amunger commented Apr 23, 2024

that co-pilot issue is the only thing that gave me some hiccups. scrolling up and down quickly causes some frames to skip while the editor is attached, but I'm pretty sure users aren't complaining about that at this point.

@amunger amunger removed their assignment Apr 23, 2024
@amunger amunger closed this as completed Apr 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants