Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet Update Tag does not work with JSX, but works file with HTML #20953

Closed
ramya-rao-a opened this issue Feb 20, 2017 · 2 comments
Closed

Emmet Update Tag does not work with JSX, but works file with HTML #20953

ramya-rao-a opened this issue Feb 20, 2017 · 2 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
April 2017

Comments

@ramya-rao-a
Copy link
Contributor

From @caiolopes in #4962 (comment)

The feature "updateTag" is not working when language mode is JavaScript React, only HTML.. And it is so useful for adding a class, etc, in an already existing component.
@ramya-rao-a ramya-rao-a self-assigned this Feb 20, 2017
@ramya-rao-a ramya-rao-a added the emmet Emmet related issues label Feb 20, 2017
@ramya-rao-a ramya-rao-a mentioned this issue Feb 20, 2017
Closed
@ramya-rao-a
Copy link
Contributor Author

Found the root cause in emmet:

The updateTag action becomes a no-op if it cannot find a context : https://github.com/emmetio/emmet/blob/328812c879b56104b7c2bf580d79650a7c20f05b/lib/action/updateTag.js#L112

And it cannot find the context due to https://github.com/emmetio/emmet/blob/328812c879b56104b7c2bf580d79650a7c20f05b/lib/utils/action.js#L163

Allowed syntaxes should allow syntaxes that extend html as well.

@ramya-rao-a ramya-rao-a added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 2, 2017
This was referenced Apr 2, 2017
Closed
Merged
ramya-rao-a added a commit that referenced this issue Apr 3, 2017
@ramya-rao-a
Fixes #1623 and #20953
067ff64
@ramya-rao-a ramya-rao-a mentioned this issue Apr 3, 2017
Merged
ramya-rao-a added a commit that referenced this issue Apr 3, 2017
@ramya-rao-a
Fixes #1623 and #20953 (#23832)
c18c4c7
@ramya-rao-a
Copy link
Contributor Author

The fix will be available in tomorrow's Insider build

@ramya-rao-a ramya-rao-a added this to the April 2017 milestone Apr 3, 2017
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Apr 3, 2017
@chrmarti chrmarti added the verified Verification succeeded label Apr 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
2 participants
@chrmarti @ramya-rao-a