Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning alert not emitted when warning audio cue not emitted #203211

Closed
rzhao271 opened this issue Jan 23, 2024 · 3 comments · Fixed by #203268
Closed

Warning alert not emitted when warning audio cue not emitted #203211

rzhao271 opened this issue Jan 23, 2024 · 3 comments · Fixed by #203268
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@rzhao271
Copy link
Contributor

Testing #203089

"Audio Cues: Line Has Warning" is set to false. "Accessibility > Alert: Warning" is set to true.

I generated a warning by using the Markdown Lint extension and writing text into a new Markdown file without an h1 header. When I turn on the audio cue, the accessibility alert also alerts me that there's a warning. When I turn off the audio cue but leave the accessibility alert on, the accessibility alert does not alert me that there's a warning.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 23, 2024
@meganrogge meganrogge added this to the December / January 2024 milestone Jan 23, 2024
@meganrogge
Copy link
Contributor

meganrogge commented Jan 23, 2024

I cannot seem to trigger a warning - can you pls give more specific instructions about how to do so? @rzhao271

Image

@rzhao271
Copy link
Contributor Author

Install the markdownlint extension.
Then create a .md file and paste in the following


Hello world!

Another line here

The extension should already generate a warning.

@meganrogge
Copy link
Contributor

Note this issue when verifying #203266. When I tested using a screen reader, the warning only appeared once. Based on debugging (the alert call happens), I believe when using a braille device, this works.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 24, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants