Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #203089: Format alert not read for format by extension #203115

Open
aiday-mar opened this issue Jan 23, 2024 · 1 comment · Fixed by #203262
Open

Testing #203089: Format alert not read for format by extension #203115

aiday-mar opened this issue Jan 23, 2024 · 1 comment · Fixed by #203262
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-signal Issues pertaining to accessibility signals bug Issue identified by VS Code Team member as probable bug
Milestone
Backlog

Comments

@aiday-mar
Copy link
Contributor

Testing #203089

So I made a little change to a testing file and forced the format of a document through the command palette. I was expecting to hear an alert that the documented was just formatted.

Screen.Recording.2024-01-23.at.09.54.01.mov
@aiday-mar aiday-mar changed the title Format alert not read Testing #203089: Format alert not read Jan 23, 2024
@meganrogge
Copy link
Contributor

It looks like that command is coming from the prettier extension, prettier.forceFormatDocument. I don't think I'm handling that case.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 23, 2024
@meganrogge meganrogge added this to the December / January 2024 milestone Jan 23, 2024
meganrogge added a commit that referenced this issue Jan 23, 2024
@meganrogge
fix #203115
79e6d75
@meganrogge meganrogge mentioned this issue Jan 23, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 23, 2024
@meganrogge meganrogge reopened this Jan 24, 2024
@meganrogge meganrogge removed the insiders-released Patch has been released in VS Code Insiders label Jan 24, 2024
@meganrogge meganrogge modified the milestones: December / January 2024, Backlog Jan 24, 2024
@meganrogge meganrogge changed the title Testing #203089: Format alert not read Testing #203089: Format alert not read for format by extension Jan 24, 2024
@meganrogge meganrogge added the accessibility-signal Issues pertaining to accessibility signals label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-signal Issues pertaining to accessibility signals bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix settings links microsoft/vscode
3 participants
@meganrogge @aiday-mar @vscodenpa