Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal sticky scroll incorrect identifies the top of buffer as a command #201260

Open
Tracked by #201690
connor4312 opened this issue Dec 20, 2023 · 9 comments
Open
Tracked by #201690
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-sticky-scroll
Milestone

Comments

@connor4312
Copy link
Member

I had a very long terminal whose lines reached the terminal's max limit, and then had an ugly sticky scroll state:

image

@AriPerkkio
Copy link

I think I've run into this same issue for couple of weeks now. Below is video where previous command jumps on top the current cursor position. I think this only happens on Bash as I've been unable to reproduce it on zsh.

Really happy to find out that disabling "Terminal: Sticky scroll" fixes this! I guess that feature was enabled by default couple of weeks ago?

vscode-terminal-sticky-scroll.mp4

@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2023

@AriPerkkio it should be enabled by default only in insiders currently.

@Tyriar Tyriar added this to the December / January 2024 milestone Dec 20, 2023
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-sticky-scroll labels Dec 20, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2023

I have also seen this happen occasionally, the repro seems to not be simply filling the scrollback unfortunately. Closing until we get good steps

@Tyriar Tyriar closed this as completed Dec 20, 2023
@Tyriar Tyriar added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Dec 20, 2023
@AriPerkkio
Copy link

I can reproduce this constantly with following script:

#!/bin/bash

var=""

for i in {1..50000}
do
   var+="\n line"
done

echo -e "$var"

Save script as repro.sh and execute it in bash inside vscode:

$ sh repro.sh
# 1. Wait for script to finish.
# 2. Press CTRL+L or what ever combination your computer registers for clearing the terminal.
# 3. Terminal should be clear now.
$ ls
$ ls
$ ls
# Output is not visible
terminal-scroll-repro.mov

@Tyriar Tyriar reopened this Dec 20, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2023

@AriPerkkio perfect thanks, looks like clearing is confusing the current command since the cursor moves upwards.

@Tyriar Tyriar removed the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Dec 20, 2023
@Tyriar Tyriar modified the milestones: December / January 2024, Backlog Dec 20, 2023
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Dec 20, 2023
@flyyuan
Copy link

flyyuan commented Feb 6, 2024

I want to fix

@tisilent
Copy link
Contributor

tisilent commented Jul 12, 2024

1
exec 'toggle sticky scroll'

@tisilent
Copy link
Contributor

2
en...

@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2024

Maybe the root cause: #166864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-sticky-scroll
Projects
None yet
Development

No branches or pull requests

5 participants