Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Git name from the view menu and assign function when you click. #19638

Closed
Tekbr opened this issue Jan 31, 2017 · 7 comments
Closed

Update Git name from the view menu and assign function when you click. #19638

Tekbr opened this issue Jan 31, 2017 · 7 comments
Assignees
Labels
debt Code quality issues git GIT issues
Milestone

Comments

@Tekbr
Copy link

Tekbr commented Jan 31, 2017

  • VSCode Version: 1.9.0 - insider fcac9b6
  • OS Version: Windows 10

-- Sorry for the English, I used Google Translator --

Update Git name from the view menu and assign function when you click.. When the SCM Preview option is disabled. See gif.

errogit

@joaomoreno joaomoreno added this to the January 2017 milestone Feb 1, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Feb 1, 2017
@joaomoreno
Copy link
Member

Reviewed by @bpasero

joaomoreno added a commit that referenced this issue Feb 1, 2017
@joaomoreno joaomoreno added candidate Issue identified as probable candidate for fixing in the next release and removed candidate Issue identified as probable candidate for fixing in the next release labels Feb 1, 2017
@Tekbr
Copy link
Author

Tekbr commented Feb 1, 2017

@joaomoreno The correction when clicking on the view menu works, but the name in the view menu still continues 'SCM', when it is disabled. Would not the correct one be written 'Git'?

Another thing, the SCM search when it is active in Command Palette is duplicate.

The 'Git' commands in the Command Palette should not be removed when SCM is enabled. Since the commands does not work?

VSCode 1.9.0 - insider 27240e7 Date 2017-02-01T11:45:10.153Z

See the above descriptions in the Gif. Sorry if I'm wrong.

errogit2

@joaomoreno
Copy link
Member

You are right, great catch.

@joaomoreno joaomoreno reopened this Feb 1, 2017
@joaomoreno joaomoreno removed the important Issue identified as high-priority label Feb 1, 2017
@joaomoreno joaomoreno modified the milestones: February 2017, January 2017 Feb 1, 2017
@joaomoreno joaomoreno added the git GIT issues label Feb 1, 2017
@Tekbr
Copy link
Author

Tekbr commented Feb 1, 2017

-- Sorry for the English, I used Google Translator --

@joaomoreno Another thing I noticed is that the amount of item in the command palette on 'Git' when the SCM is disabled is less than the amount of item when SCM is active. Is that a problem too?

Disable SCM> Item Git Command Palette = 15
SCM Enabled> Item Git Command Palette = 23

Another example is the 'Git: Show Git Output' is not displayed when SCM is disabled, but appears when we open the Output. And when SCM is enabled it is displayed in the Command Palette, but it does not appear when opening the Output.

See the above descriptions in the Gif. Sorry if I'm wrong.

errogit3

@joaomoreno
Copy link
Member

That is expected. The SCM is in Preview mode and isn't fully implemented. You can track its progress in #18615

@joaomoreno joaomoreno modified the milestones: March 2017, February 2017 Feb 21, 2017
@joaomoreno joaomoreno modified the milestones: March 2017, April 2017 Mar 30, 2017
@joaomoreno joaomoreno modified the milestones: May 2017, April 2017 Apr 24, 2017
@joaomoreno joaomoreno added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Apr 25, 2017
@Tekbr
Copy link
Author

Tekbr commented May 8, 2017

@joaomoreno When SCM is active the name Git still remains in the menu instead of SCM. The SCM Shortcut is also not appearing in the Menu. VSCode Version 1.12.1

git

I know Git is about to be "removed" in the next version. In VSCode Insiders - 1.13.0 it does not even appear anymore. The problem of not being able to click on the menu when SCM is active has happened again. The Git name is still there and you can not click on it and the shortcut is not appearing either.

git2

@joaomoreno
Copy link
Member

Oh forgot to update this, thanks @Tekbr

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues git GIT issues
Projects
None yet
Development

No branches or pull requests

2 participants