Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear what part of the editor is dimmed #191608

Closed
bpasero opened this issue Aug 29, 2023 · 3 comments · Fixed by #191642
Closed

Unclear what part of the editor is dimmed #191608

bpasero opened this issue Aug 29, 2023 · 3 comments · Fixed by #191642
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-dim-unfocused Related to the accessibility.dimUnfocused.* feature
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2023 •
edited
Loading

Testing #191527

The setting seems to suggest the editor gets dimmed, but I was also expecting breadcrumbs and maybe tabs to get dimmed. Also, editor controls (like find input) do not seem to get dimmed.

Image
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2023
@Tyriar Tyriar added this to the August 2023 milestone Aug 29, 2023
Tyriar added a commit that referenced this issue Aug 29, 2023
@Tyriar
Dim breadcrumbs
406091a 
Fixes #191608
@Tyriar Tyriar mentioned this issue Aug 29, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2023
@aiday-mar aiday-mar added the verified Verification succeeded label Aug 30, 2023
@Tyriar Tyriar mentioned this issue Aug 30, 2023
Merged
@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2023

Reopening breadcrumbs not dimming due to #191852

@Tyriar Tyriar reopened this Aug 30, 2023
@Tyriar Tyriar removed the verified Verification succeeded label Aug 30, 2023
@Tyriar Tyriar modified the milestones: August 2023, September 2023 Aug 30, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Aug 30, 2023
@Tyriar Tyriar mentioned this issue Aug 30, 2023
Closed
Tyriar added a commit that referenced this issue Aug 30, 2023
@Tyriar
Partially revert a change that broke dimming in active group
d89cac9 
Reopens #191608
@Tyriar Tyriar modified the milestones: September 2023, Backlog Sep 25, 2023
@Tyriar Tyriar added the workbench-dim-unfocused Related to the accessibility.dimUnfocused.* feature label Dec 19, 2024
@Tyriar Tyriar mentioned this issue Dec 19, 2024
Open
@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2024

Merging into #236576

/duplicate

@vs-code-engineering vs-code-engineering bot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 19, 2024
@vs-code-engineering VS Code Engineering
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-dim-unfocused Related to the accessibility.dimUnfocused.* feature
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Action feedback on dim unfocused view feature microsoft/vscode
4 participants
@bpasero @Tyriar @aiday-mar @vscodenpa