Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onCancel handler was attached after the promise settled #182624

Closed
ulugbekna opened this issue May 16, 2023 · 2 comments · Fixed by #182629
Closed

onCancel handler was attached after the promise settled #182624

ulugbekna opened this issue May 16, 2023 · 2 comments · Fixed by #182629
Assignees
@aeschli
Labels
insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Milestone
May 2023

Comments

@ulugbekna
Copy link
Contributor

ulugbekna commented May 16, 2023 •
edited
Loading

Build failure:

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=214712&view=logs&j=55ac390b-ffb1-50ea-3650-525dd9a3fd80&t=0beb721c-bc23-58b2-a0a2-2fceaa3e6b2b&l=22

@joaomoreno says one of these may be related:
#179105 or #179149
@ulugbekna ulugbekna added the vscode-build VS Code build process issues label May 16, 2023
@aeschli
Copy link
Contributor

aeschli commented May 16, 2023

See sindresorhus/got#1489

I suggest we move to node-fetch so that when we are on node 18 we can replace if with the built-in fetch.

aeschli added a commit that referenced this issue May 16, 2023
@aeschli
replace 'got' with 'node-fetch' (for #182624)
9e1b8fb
@aeschli aeschli mentioned this issue May 16, 2023
Merged
@bpasero bpasero added this to the May 2023 milestone May 16, 2023
@bpasero bpasero removed their assignment May 16, 2023
@bpasero
Copy link
Member

bpasero commented May 16, 2023

Thanks Martin.

aeschli added a commit that referenced this issue May 17, 2023
@aeschli
replace 'got' with 'node-fetch' (#182629)
f1258a5 
replace 'got' with 'node-fetch' (for #182624)
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

replace 'got' with 'node-fetch' microsoft/vscode
4 participants
@bpasero @aeschli @ulugbekna @vscodenpa