-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect "stopped" event handling #181966
Comments
Bring back the async queue for handling debug messages, but be sure that refreshTopOfCallstack will always resolve its promises and won't make the queue stuck Fix #181966
When verifying, test with one of the multi-threaded examples here (#29168) the sample dev containers are helpful for getting a debug environment for C# or C++ too. Previous issues: |
Bring back the async queue for handling debug messages, but be sure that refreshTopOfCallstack will always resolve its promises and won't make the queue stuck Fix #181966
Hm, stopped and restarted the debug session, am now able to step over that second breakpoint 🤔 I'll consider this verified for now |
Not sure about that, but also all the issue reports have gone away so I think it's ok. I just tested it with C# for a bit and it's working fine for me. |
The supposed fix doesn't really work though, it's still broken in 1.79: goblint/GobPie#60 (comment). |
I'm not following the comments in the issue, can you help me understand what is still an issue in vscode? A sample that I can repro would be great |
From #181485
Need a better fix for the underlying issue at
vscode/src/vs/workbench/contrib/debug/common/debugModel.ts
Lines 1313 to 1336 in 5967add
then to bring back the change from #181855
The text was updated successfully, but these errors were encountered: