Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow switching how content is dropped #179430

Open
mjbvz opened this issue Apr 7, 2023 · 1 comment
Open

Allow switching how content is dropped #179430

mjbvz opened this issue Apr 7, 2023 · 1 comment
Assignees
@mjbvz
Labels
api api-proposal feature-request Request for new features or functionality
Milestone
On Deck

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 7, 2023

Related to #156384

When multiple drop providers are registered, we should allow selecting which one is used on drop. This includes letting users fall back to dropping the item as plaintext

Main requirements:

  • When dropping into an editor, if multiple drop edits are returned, apply the best automatically by default but then show some sort of UI to change how the contents are dropping
  • Add a setting so that users can configure the default drop provider per language
@mjbvz mjbvz added the api label Apr 7, 2023
@mjbvz mjbvz added this to the April 2023 milestone Apr 7, 2023
@mjbvz mjbvz self-assigned this Apr 7, 2023
@mjbvz mjbvz added the feature-request Request for new features or functionality label Apr 7, 2023
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 7, 2023

Learnings from this also apply to copy paste providers

Will likely require some API additions to:

  • Give drops a human readable name to show in the UI
  • Give drops a id that we can use in the settings

mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 7, 2023
@mjbvz
Prototype drop feedback UX
c308e71 
For microsoft#179430

Adds two new UX components:

- An inline progress icon shown when a drop operation takes over 500ms. This replaces the notification. You can click on it to cancel the drop

- Post drop, a drop feedback icon that lets you drop the file in a different way. This lets you drop the file as plain text for instance instead of as a markdown link
@mjbvz mjbvz mentioned this issue Apr 7, 2023
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 11, 2023
@mjbvz
Add drop feedback UX
b45c925 
For microsoft#179430

Adds two new UX components:

- An inline progress icon shown when a drop operation takes over 500ms. This replaces the notification. You can click on it to cancel the drop

- Post drop, a drop feedback icon that lets you drop the file in a different way. This lets you drop the file as plain text for instance instead of as a markdown link
mjbvz added a commit that referenced this issue Apr 11, 2023
@mjbvz
Add drop feedback UX (#179434)
e926267 
For #179430

Adds two new UX components:

- An inline progress icon shown when a drop operation takes over 500ms. This replaces the notification. You can click on it to cancel the drop

- Post drop, a drop feedback icon that lets you drop the file in a different way. This lets you drop the file as plain text for instance instead of as a markdown link
@mjbvz mjbvz mentioned this issue Apr 24, 2023
Closed
3 tasks
@mjbvz mjbvz modified the milestones: April 2023, May 2023 Apr 24, 2023
@mjbvz mjbvz modified the milestones: May 2023, June 2023 May 25, 2023
@mjbvz mjbvz modified the milestones: June 2023, July 2023 Jun 12, 2023
@mjbvz mjbvz modified the milestones: July 2023, August 2023 Jul 18, 2023
mjbvz added a commit that referenced this issue Aug 8, 2023
@mjbvz
Move await from priority for drop/paste API proposals
1740397 
For #179430, #30066

Switching to use `yieldTo` instead of `priority` to let an extension de-rank itself in the list of edits. `priority` was an arbitrary number while `yieldTo` gives more control over how the ranking takes place
@mjbvz mjbvz mentioned this issue Aug 8, 2023
Merged
mjbvz added a commit that referenced this issue Aug 8, 2023
@mjbvz
priority -> yieldTo for drop/paste API proposals (#189881)
39df243 
Move await from `priority` for drop/paste API proposals

For #179430, #30066

Switching to use `yieldTo` instead of `priority` to let an extension de-rank itself in the list of edits. `priority` was an arbitrary number while `yieldTo` gives more control over how the ranking takes place
mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 8, 2023
@mjbvz
Move drop/paste ids onto providers
2570eb4 
For microsoft#179430, microsoft#30066

This lets us call just the provider we are interested in
@mjbvz mjbvz mentioned this issue Aug 8, 2023
Merged
mjbvz added a commit that referenced this issue Aug 8, 2023
@mjbvz
Move drop/paste ids onto providers (#189961)
8c77472 
For #179430, #30066

This lets us call just the provider we are interested in
mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 14, 2023
@mjbvz
Add experimental default drop setting and fix yieldTo ordering
af32069 
For microsoft#179430
@mjbvz mjbvz mentioned this issue Aug 14, 2023
Merged
mjbvz added a commit that referenced this issue Aug 15, 2023
@mjbvz
Add experimental default drop setting and fix yieldTo ordering (#19…
6f36672 
…0459)

For #179430
@mjbvz mjbvz modified the milestones: August 2023, September 2023 Aug 22, 2023
@mjbvz mjbvz modified the milestones: September 2023, October 2023 Sep 12, 2023
@mjbvz mjbvz modified the milestones: October 2023, November 2023 Oct 16, 2023
@mjbvz mjbvz modified the milestones: November 2023, On Deck Nov 13, 2023
@mjbvz mjbvz modified the milestones: On Deck, March 2024 Mar 11, 2024
@mjbvz mjbvz modified the milestones: March 2024, April 2024 Mar 25, 2024
@mjbvz mjbvz modified the milestones: April 2024, May 2024 Apr 22, 2024
@mjbvz mjbvz mentioned this issue Apr 23, 2024
Closed
3 tasks
@mjbvz mjbvz modified the milestones: May 2024, June 2024 May 23, 2024
@mjbvz mjbvz modified the milestones: June 2024, July 2024 Jun 17, 2024
@mjbvz mjbvz modified the milestones: July 2024, August 2024 Jul 16, 2024
@mjbvz mjbvz modified the milestones: August 2024, September 2024 Aug 19, 2024
@mjbvz mjbvz modified the milestones: September 2024, On Deck Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
api api-proposal feature-request Request for new features or functionality
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
1 participant
@mjbvz