Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support title bar within native title bar #172464

Closed
TylerLeonhardt opened this issue Jan 25, 2023 · 10 comments · Fixed by #202585
Closed

Support title bar within native title bar #172464

TylerLeonhardt opened this issue Jan 25, 2023 · 10 comments · Fixed by #202585
Assignees
Labels
command-center feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan

Comments

@TylerLeonhardt
Copy link
Member

Testing #171999

I enabled native tabs and the command center and no command center showed up:
image

I think the command center should come under the native tabs if it's enabled maybe.

@bpasero
Copy link
Member

bpasero commented Jan 26, 2023

I am not sure about that, there are people that prefer native window title or use native tabs and in those cases we do not have a custom title area to add our controls. Forcing to have yet another row of things (you already have 2 with native tabs I think) seems strange to me.

@deepak1556
Copy link
Collaborator

Yeah given we cannot draw on the native titlebar, I don't think taking up valuable editor area space for command center seems like a good idea.

@deepak1556 deepak1556 added the under-discussion Issue is under discussion for relevance, priority, approach label Jan 26, 2023
@sbatten
Copy link
Member

sbatten commented Jan 26, 2023

Right now command center is not default behaviour so in that case, it could make sense that this was an explicit decision by the user, but if the intent is to have CC as default, I don't think it would be right to show an extra row just for that, especially on macOS where the layout controls are the only other thing in that area.

@TylerLeonhardt
Copy link
Member Author

All fair points. I opened this because I predict such an issue, not because I actually want it.

Maybe we revisit if we get other controls in the title bar (like debug).

Or maybe we surface the command center somewhere else. Like an icon to the right of the tabs or something.

@deepak1556 deepak1556 removed their assignment Jan 27, 2023
@wesleyboar
Copy link

wesleyboar commented Sep 11, 2023

Related? To deal with this, I opened tabs on macOS VS Code (using a keyboard shortcut while windows.nativeTabs: false) and Command Center (via window.commandCenter: true), but the UI of tabs and command center overlapped for me (#192801).

@wesleyboar
Copy link

wesleyboar commented Sep 12, 2023

To avoid adding a new line, could the command center be a tab? When you click on it, instead of opening an editor, your current editor remains open and the command center does what it would have done in another location. The tab could be long enough to hold the layout buttons. But, the more I write this idea, the more I feel it is a misuse of UI patterns...

Edit: I think "Like an icon to the right of the tabs […]" is a more fitting idea than mine.

@jrieken jrieken added the feature-request Request for new features or functionality label Dec 5, 2023
@jrieken jrieken added this to the Backlog milestone Dec 5, 2023
@joaomoreno joaomoreno changed the title Can't use window.nativeTabs with window.commandCenter Support window.commandCenter with window.nativeTabs Dec 15, 2023
@joaomoreno joaomoreno removed the under-discussion Issue is under discussion for relevance, priority, approach label Dec 15, 2023
@joaomoreno joaomoreno modified the milestones: Backlog, December / January 2024 Dec 15, 2023
@joaomoreno joaomoreno changed the title Support window.commandCenter with window.nativeTabs Support title bar with native title bar Dec 15, 2023
@joaomoreno joaomoreno changed the title Support title bar with native title bar Support title bar within native title bar Dec 15, 2023
@rickardp
Copy link

rickardp commented Jan 5, 2024

An alternative would be to implement the tabs in the product itself rather than relying on OS functionality. This would also make the much superior window management provided by the tabs available on all platforms.

At least for me, I don't care about if the tabs are native or not, I just don't want to be bothered with 10 different VSCode windows floating around everywhere (just as we are now using browsers).

JetBrains IDEs already does this.

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Jan 5, 2024

An alternative would be to implement the tabs in the product itself rather than relying on OS functionality.

@rickardp We already do this. This issue is specifically about when the user wants to use native tabs. There's a setting to control which tabs experience you get.

@rickardp
Copy link

rickardp commented Jan 5, 2024

An alternative would be to implement the tabs in the product itself rather than relying on OS functionality.

@rickardp We already do this. This issue is specifically about when the user wants to use native tabs. There's a setting to control which tabs experience you get.

I was not aware this functionality existed. I always used native tabs to accomplish this behaviour. How can I group multiple open projects into a single window using tabs, without using native tabs?

EDIT: It probably goes without saying, but just to clarify: I am not talking about editor tabs, but project tabs, the way the native tabs work

@TylerLeonhardt
Copy link
Member Author

EDIT: It probably goes without saying, but just to clarify: I am not talking about editor tabs, but project tabs, the way the native tabs work

Yep, my bad. This was the clarity I needed. We don't support this today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
command-center feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

11 participants