"]633;SetMark;Id=s0;Hidden" shows up in Test Peek Error windows

[DanTup]

When I'm running tests recently, I'm seeing this weird markup show up in the "Peek Error" pane:

This markup is not in the original text I'm providing to the TestRun.appendOutput call, but it looks like it's something VS Code is using itself:

vscode/src/vs/workbench/contrib/testing/common/testResult.ts

Line 131 in 90e165a

const getMarkCode = (marker: number, start: boolean) => `\x1b]633;SetMark;Id=${getMarkId(marker, start)};Hidden\x07`;

I'm not sure what's triggering it (it doesn't seem to show up in all output messages, only some) but perhaps @connor4312 (who seems to have worked on that code) will understand what's going on.

[DanTup]

Also, I don't know if it's related, but the last item seems to be duplicated in the test output compared to what was sent to appendOutput:

[fabioz]

This happens to me too.

[DanTup]

@connor4312 thanks! The markers are gone, although I still see the last item duplicated (the last one has line numbers but the one before does not, oddly). Not sure if I'm causing this or not?

[aeschli]

Marking as verified as the fix for the original issue got verified.

@DanTup Can you file a new issue for the duplicate entry?

[DanTup]

Turns out, the duplication is kinda my fault, but I don't think I can improve it so I'm interested in ideas.

My test runner sends events for output, including error output, and then a failure status at the end:

1. output: message 1
2. error output: expectation failed
3. test failed

The duplication comes because I write all output events as they arrive using TestRun.appendOutput, but the current API for TestRun.failed() also requires a message, so I'm giving it the last one again.

TestRun.failed() can also take an array of messages, but if I give it an empty array, then the Peek Error window doesn't open like it does if it's given a message.

There doesn't seem a great solution to this from my side. I'd rather not try to buffer messages because they could lead to a delay in the user seeing output, or events appearing out of order if not done correctly. Is it feasible VS Code could support some way to disconnect marking a test as failed from its error output? For example an appendErrorOutput() and then allowing a TestRun.failed() without output, and it can just use the last event itself?

@connor4312