Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move updateService.initialize into the update service awaiting LifecyclePhase.AfterWindowOpen #160135

Closed
bpasero opened this issue Sep 6, 2022 · 1 comment · Fixed by #176429
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 6, 2022

// Initialize update service
const updateService = accessor.get(IUpdateService);
if (updateService instanceof Win32UpdateService || updateService instanceof LinuxUpdateService || updateService instanceof DarwinUpdateService) {
await updateService.initialize();
}

I suggest to either remove the await that was introduced 2 months ago or better listen to the LifecycleMainPhase.AfterWindowOpen and move this code into the update service.

@bpasero bpasero added the debt Code quality issues label Sep 6, 2022
@bpasero bpasero added this to the September 2022 milestone Sep 6, 2022
@bpasero bpasero changed the title Do not block after window open and/or move to update service Move updateService.initialize into the update service awaiting LifecyclePhase.AfterWindowOpen Sep 6, 2022
@bpasero
Copy link
Member Author

bpasero commented Sep 13, 2022

As discussed, maybe product.target would be a way out, since we already encode this information in the product.

@joaomoreno joaomoreno modified the milestones: February 2023, March 2023 Feb 22, 2023
joaomoreno added a commit that referenced this issue Mar 9, 2023
* Remove hardcoded update service participation

fixes #160135

* fix protected fields

* remove race
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants