-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve source path matching #1591
Comments
👍 |
Nice |
this isn't just source path mapping btw, it doesn't support remote debugging for node either although maybe that's done on purpose and isn't a lot of work to re-enable/enable that. |
@silverbp yes, remote debugging requires more (for one, node's debug port cannot be accessed externally so a proxy or forwarding mechanism is always required). |
@weinand Somewhere along the line node is no longer binding the debug port to 127.0.0.1, because you can now get to it externally, at least on node 5.0+. I was using balance to forward the port out of the container, but it's no longer required. I guess I was referring to the fact that vscode no longer supports an address property when attaching to a node process. |
@weinand for instance with node cli, I can do: |
@silverbp yes, we've removed the address attribute because earlier versions of node did not support external addresses and it was confusing users. I've created microsoft/vscode-node-debug#32 to add the "address" attribute back for the January drop. |
the VSCode debugger architecture assumes that debugger, debug-adapter and VSCode sit on the same filesystem and refer to files through the exact same path.
This makes it impossible to use VSCode in remote debugging scenarios, e.g. Docker setups.
The text was updated successfully, but these errors were encountered: