Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve source path matching #1591

Closed
weinand opened this issue Dec 22, 2015 · 7 comments
Closed

improve source path matching #1591

weinand opened this issue Dec 22, 2015 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Dec 22, 2015

the VSCode debugger architecture assumes that debugger, debug-adapter and VSCode sit on the same filesystem and refer to files through the exact same path.
This makes it impossible to use VSCode in remote debugging scenarios, e.g. Docker setups.

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 22, 2015
@weinand weinand self-assigned this Dec 22, 2015
@weinand weinand added this to the Jan 2016 milestone Dec 22, 2015
@silverbp
Copy link

👍

@rnordin100
Copy link

Nice

@silverbp
Copy link

this isn't just source path mapping btw, it doesn't support remote debugging for node either although maybe that's done on purpose and isn't a lot of work to re-enable/enable that.

@weinand
Copy link
Contributor Author

weinand commented Dec 23, 2015

@silverbp yes, remote debugging requires more (for one, node's debug port cannot be accessed externally so a proxy or forwarding mechanism is always required).
But this feature-request is only about the path matching aspect.

@silverbp
Copy link

@weinand Somewhere along the line node is no longer binding the debug port to 127.0.0.1, because you can now get to it externally, at least on node 5.0+. I was using balance to forward the port out of the container, but it's no longer required. I guess I was referring to the fact that vscode no longer supports an address property when attaching to a node process.

@silverbp
Copy link

@weinand for instance with node cli, I can do: node debug 192.168.99.100:5858 but vscode only lets you attach to a port and doesn't let you specify the address.

@weinand
Copy link
Contributor Author

weinand commented Dec 24, 2015

@silverbp yes, we've removed the address attribute because earlier versions of node did not support external addresses and it was confusing users. I've created microsoft/vscode-node-debug#32 to add the "address" attribute back for the January drop.

@egamma egamma mentioned this issue Jan 6, 2016
59 tasks
@egamma egamma mentioned this issue Feb 1, 2016
97 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants