Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run code server task gets recreated #158886

Closed
weinand opened this issue Aug 23, 2022 · 7 comments · Fixed by #159233
Closed

Run code server task gets recreated #158886

weinand opened this issue Aug 23, 2022 · 7 comments · Fixed by #159233
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Milestone
August 2022

Comments

@weinand
Copy link
Contributor

weinand commented Aug 23, 2022 •
edited
Loading

Testing #158787

  • open vscode workspace in VS Code
  • F1 -> "Run Task" -> "Run Code Server"

Observe: a task shows up:
CleanShot 2022-08-23 at 14 09 54@2x

  • F1 -> "Reload Window"

Observe: another "Run Code Server" shows up:
CleanShot 2022-08-23 at 14 11 05@2x
@weinand weinand mentioned this issue Aug 23, 2022
Closed
3 tasks
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Aug 23, 2022
@Tyriar Tyriar removed their assignment Aug 23, 2022
@meganrogge
Copy link
Contributor

This should not be happening, but also don't believe this kind of task should be persisted, so will be fixed when #158790 is

@meganrogge
Copy link
Contributor

were you able to reproduce the issue with a build task?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Aug 23, 2022
@meganrogge meganrogge added this to the September 2022 milestone Aug 23, 2022
@weinand
Copy link
Contributor Author

weinand commented Aug 23, 2022

@meganrogge no, the issue only occurred for the "Run Code Server" task. The build task and all the others I tried worked fine.

@meganrogge
Copy link
Contributor

likely /closedWith 95e0f54

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 23, 2022
@rzhao271 rzhao271 modified the milestones: September 2022, August 2022 Aug 25, 2022
@rzhao271 rzhao271 removed the info-needed Issue requires more information from poster label Aug 25, 2022
@andreamah andreamah added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Aug 25, 2022
@andreamah
Copy link
Contributor

Seems that it's still happening:

image

@andreamah andreamah reopened this Aug 25, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Aug 25, 2022
@meganrogge meganrogge changed the title Reload window creates new task Run code server task gets recreated Aug 25, 2022
@meganrogge meganrogge removed the verification-found Issue verification failed label Aug 25, 2022
@meganrogge
Copy link
Contributor

the persistent task's map key and the one before reload are diff't 🤔

@meganrogge
Copy link
Contributor

getCommonTaskId is what I should be using I think. that fixes this issue

meganrogge added a commit that referenced this issue Aug 25, 2022
@meganrogge
fix #158886
a489836
@meganrogge meganrogge mentioned this issue Aug 25, 2022
Merged
meganrogge added a commit that referenced this issue Aug 26, 2022
@meganrogge
use common task ID instead of map key (#159233)
35b971c 
* fix #158886

* Update src/vs/workbench/contrib/terminal/test/browser/links/terminalLocalLinkDetector.test.ts
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 26, 2022
@alexr00 alexr00 added the verified Verification succeeded label Aug 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

use common task ID instead of map key microsoft/vscode
7 participants
@weinand @Tyriar @rzhao271 @meganrogge @andreamah @alexr00 @vscodenpa