Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track usage of internal snippet syntax #15573

Closed
14 of 16 tasks
jrieken opened this issue Nov 16, 2016 · 8 comments
Closed
14 of 16 tasks

Track usage of internal snippet syntax #15573

jrieken opened this issue Nov 16, 2016 · 8 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Nov 16, 2016

With #3210 we are adding API to inserts snippets via completions. These snippets use the same syntax external, static snippets use which again is a subset of the TextMate snippet syntax. Eventually, we will not support the internal snippet syntax anymore.

This issue lists extensions that are known to be using the internal syntax and tracks their adoption of the new API.

@jrieken jrieken self-assigned this Nov 16, 2016
@jrieken jrieken added this to the November 2016 milestone Nov 16, 2016
@jrieken jrieken added the debt Code quality issues label Nov 16, 2016
@jrieken
Copy link
Member Author

jrieken commented Nov 17, 2016

Some extensions depend on the LSP to have support for this as well - #15577

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2016

@jrieken Is there a spec for the new syntax?

@jrieken
Copy link
Member Author

jrieken commented Nov 24, 2016

Yeah - this should be a more or less precise descriptions: https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/snippet/common/snippet.md

aeschli added a commit to microsoft/vscode-css-languageservice that referenced this issue Nov 24, 2016
aeschli added a commit to microsoft/vscode-html-languageservice that referenced this issue Nov 24, 2016
@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2016

@jrieken Can you spec the escaping rule in case a text contains $1 or ${... or the placeholder text contains a '}'

@aeschli
Copy link
Contributor

aeschli commented Nov 25, 2016

I created #16056 for issues around escaping.

aeschli added a commit to microsoft/vscode-json-languageservice that referenced this issue Nov 25, 2016
@aeschli aeschli removed their assignment Dec 2, 2016
@jrieken jrieken modified the milestones: November 2016, January 2017 Dec 5, 2016
@DanTup
Copy link
Contributor

DanTup commented Dec 15, 2016

FYI - Dart Code now uses the new API :-)

Our use of the old API seemed to break in 1.8 - underscores were being inserted during completion. Updating seemed like a faster option than waiting for a fix, but it does mean people upgrading to 1.8 need to then upgrade Dart Code (they can't do it before, since the new version had to have engine: 1.8) for things to work properly.

@jrieken jrieken modified the milestone: January 2017 Jan 5, 2017
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 17, 2017

This is done for the Go extension as well. Checking off the box for Go

microsoft/vscode-go#709

@jrieken
Copy link
Member Author

jrieken commented May 8, 2017

Removal is happening in May

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

4 participants