Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: background/watch task reconnection #155349

Closed
3 tasks done
meganrogge opened this issue Jul 15, 2022 · 1 comment
Closed
3 tasks done

Test: background/watch task reconnection #155349

meganrogge opened this issue Jul 15, 2022 · 1 comment

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Jul 15, 2022

Refs #117408

Authors: @meganrogge @Tyriar

Complexity: 3

Create Issue


Watch tasks can now be reconnected to on window reload. Verify that this does not happen by default.

Then verify that it works via task.experimental.reconnection

Note that the setting will only take effect for terminals you create in the future.

Good examples are the VS Code - Build task and xterm.js watch task. Both can be activated via the command palette or Ctrl/Cmd+Shift+B.

Make sure that you can kill the terminals and run the task again without issues, that the problems update, and anything else you can think of

Known issues:

@rebornix
Copy link
Member

rebornix commented Jul 26, 2022

Thanks, it works great.

After using external terminal for build/watch VS Code for 6 years, finally I don't have to use it anymore since the combination of daemon tasks and task restore covers it well (once #156294 fixed). Kudos to @meganrogge @Tyriar @joaomoreno !

@rebornix rebornix removed their assignment Jul 26, 2022
@karrtikr karrtikr removed their assignment Jul 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants